Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/external_tab_container_win.cc

Issue 8551002: browser: Add missing OVERRIDE annotation to ExternalTabContainer implementing TabContentsDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm ShowPageInfo Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/external_tab_container_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_tab_container_win.cc
diff --git a/chrome/browser/external_tab_container_win.cc b/chrome/browser/external_tab_container_win.cc
index bf504a691cad16e227a44944d00480ec63ca1f68..6e309d1794ed2232ffa9e01f460410be6e07a735 100644
--- a/chrome/browser/external_tab_container_win.cc
+++ b/chrome/browser/external_tab_container_win.cc
@@ -536,7 +536,7 @@ TabContentsWrapper* ExternalTabContainer::GetConstrainingContentsWrapper(
return source;
}
-bool ExternalTabContainer::IsPopup(const TabContents* source) const {
+bool ExternalTabContainer::IsPopupOrPanel(const TabContents* source) const {
return is_popup_window_;
}
@@ -587,26 +587,6 @@ bool ExternalTabContainer::CanDownload(TabContents* source, int request_id) {
return false;
}
-void ExternalTabContainer::ShowPageInfo(Profile* profile,
- const GURL& url,
- const NavigationEntry::SSLStatus& ssl,
- bool show_history) {
- POINT cursor_pos = {0};
- GetCursorPos(&cursor_pos);
-
- gfx::Rect bounds;
- bounds.set_origin(gfx::Point(cursor_pos));
-
- PageInfoBubbleView* page_info_bubble =
- new ExternalTabPageInfoBubbleView(this, NULL, profile, url,
- ssl, show_history);
- Bubble* bubble = Bubble::Show(GetWidget(), bounds,
- views::BubbleBorder::TOP_LEFT,
- views::BubbleBorder::ALIGN_ARROW_TO_MID_ANCHOR,
- page_info_bubble, page_info_bubble);
- page_info_bubble->set_bubble(bubble);
-}
-
void ExternalTabContainer::RegisterRenderViewHostForAutomation(
RenderViewHost* render_view_host, bool pending_view) {
if (render_view_host) {
« no previous file with comments | « chrome/browser/external_tab_container_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698