Chromium Code Reviews| Index: webkit/glue/resource_fetcher.cc |
| diff --git a/webkit/glue/resource_fetcher.cc b/webkit/glue/resource_fetcher.cc |
| index ae8c917aa6fdf7af1d7011c54e503ec6bbd08a5a..a064a6954814c3f13e29cfffd35e7c88c3004841 100644 |
| --- a/webkit/glue/resource_fetcher.cc |
| +++ b/webkit/glue/resource_fetcher.cc |
| @@ -24,7 +24,7 @@ namespace webkit_glue { |
| ResourceFetcher::ResourceFetcher(const GURL& url, WebFrame* frame, |
| WebURLRequest::TargetType target_type, |
| - Callback* callback) |
| + const Callback& callback) |
| : url_(url), |
| target_type_(target_type), |
| completed_(false), |
| @@ -58,14 +58,14 @@ void ResourceFetcher::Start(WebFrame* frame) { |
| void ResourceFetcher::RunCallback(const WebURLResponse& response, |
| const std::string& data) { |
| - if (!callback_.get()) |
| + if (callback_.is_null()) |
| return; |
| // Take care to clear callback_ before running the callback as it may lead to |
| // our destruction. |
|
awong
2011/11/21 21:46:56
Update similar to image_resource_fetcher.cc
dcheng
2011/11/21 22:04:16
Done.
|
| - scoped_ptr<Callback> callback; |
| - callback.swap(callback_); |
| - callback->Run(response, data); |
| + Callback callback = callback_; |
| + callback_.Reset(); |
| + callback.Run(response, data); |
| } |
| ///////////////////////////////////////////////////////////////////////////// |
| @@ -125,7 +125,7 @@ void ResourceFetcher::didFail(WebURLLoader* loader, const WebURLError& error) { |
| ResourceFetcherWithTimeout::ResourceFetcherWithTimeout( |
| const GURL& url, WebFrame* frame, WebURLRequest::TargetType target_type, |
| - int timeout_secs, Callback* callback) |
| + int timeout_secs, const Callback& callback) |
| : ResourceFetcher(url, frame, target_type, callback) { |
| timeout_timer_.Start(FROM_HERE, TimeDelta::FromSeconds(timeout_secs), this, |
| &ResourceFetcherWithTimeout::TimeoutFired); |