Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: webkit/glue/resource_fetcher.cc

Issue 8550010: base::Bind() conversion for webkit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/resource_fetcher.h ('k') | webkit/glue/resource_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/resource_fetcher.cc
diff --git a/webkit/glue/resource_fetcher.cc b/webkit/glue/resource_fetcher.cc
index ae8c917aa6fdf7af1d7011c54e503ec6bbd08a5a..10a0b690d69a48b58d1bde6f6914788a7bb0f16e 100644
--- a/webkit/glue/resource_fetcher.cc
+++ b/webkit/glue/resource_fetcher.cc
@@ -24,7 +24,7 @@ namespace webkit_glue {
ResourceFetcher::ResourceFetcher(const GURL& url, WebFrame* frame,
WebURLRequest::TargetType target_type,
- Callback* callback)
+ const Callback& callback)
: url_(url),
target_type_(target_type),
completed_(false),
@@ -58,14 +58,13 @@ void ResourceFetcher::Start(WebFrame* frame) {
void ResourceFetcher::RunCallback(const WebURLResponse& response,
const std::string& data) {
- if (!callback_.get())
+ if (callback_.is_null())
return;
- // Take care to clear callback_ before running the callback as it may lead to
- // our destruction.
- scoped_ptr<Callback> callback;
- callback.swap(callback_);
- callback->Run(response, data);
+ // Take a reference to the callback as running the callback may lead to our
+ // destruction.
+ Callback callback = callback_;
+ callback.Run(response, data);
}
/////////////////////////////////////////////////////////////////////////////
@@ -125,7 +124,7 @@ void ResourceFetcher::didFail(WebURLLoader* loader, const WebURLError& error) {
ResourceFetcherWithTimeout::ResourceFetcherWithTimeout(
const GURL& url, WebFrame* frame, WebURLRequest::TargetType target_type,
- int timeout_secs, Callback* callback)
+ int timeout_secs, const Callback& callback)
: ResourceFetcher(url, frame, target_type, callback) {
timeout_timer_.Start(FROM_HERE, TimeDelta::FromSeconds(timeout_secs), this,
&ResourceFetcherWithTimeout::TimeoutFired);
« no previous file with comments | « webkit/glue/resource_fetcher.h ('k') | webkit/glue/resource_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698