Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: webkit/glue/image_resource_fetcher.cc

Issue 8550010: base::Bind() conversion for webkit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/image_resource_fetcher.h ('k') | webkit/glue/resource_fetcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/glue/image_resource_fetcher.h" 5 #include "webkit/glue/image_resource_fetcher.h"
6 6
7 #include "base/callback.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h"
8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h" 9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
9 #include "ui/gfx/size.h" 10 #include "ui/gfx/size.h"
10 #include "webkit/glue/image_decoder.h" 11 #include "webkit/glue/image_decoder.h"
11 #include "third_party/skia/include/core/SkBitmap.h" 12 #include "third_party/skia/include/core/SkBitmap.h"
12 13
13 using WebKit::WebFrame; 14 using WebKit::WebFrame;
14 using WebKit::WebURLRequest; 15 using WebKit::WebURLRequest;
15 using WebKit::WebURLResponse; 16 using WebKit::WebURLResponse;
16 17
17 namespace webkit_glue { 18 namespace webkit_glue {
18 19
19 ImageResourceFetcher::ImageResourceFetcher( 20 ImageResourceFetcher::ImageResourceFetcher(
20 const GURL& image_url, 21 const GURL& image_url,
21 WebFrame* frame, 22 WebFrame* frame,
22 int id, 23 int id,
23 int image_size, 24 int image_size,
24 WebURLRequest::TargetType target_type, 25 WebURLRequest::TargetType target_type,
25 Callback* callback) 26 const Callback& callback)
26 : callback_(callback), 27 : callback_(callback),
27 id_(id), 28 id_(id),
28 image_url_(image_url), 29 image_url_(image_url),
29 image_size_(image_size) { 30 image_size_(image_size) {
30 fetcher_.reset(new ResourceFetcher( 31 fetcher_.reset(new ResourceFetcher(
31 image_url, frame, target_type, 32 image_url, frame, target_type,
32 NewCallback(this, &ImageResourceFetcher::OnURLFetchComplete))); 33 base::Bind(&ImageResourceFetcher::OnURLFetchComplete,
34 base::Unretained(this))));
33 } 35 }
34 36
35 ImageResourceFetcher::~ImageResourceFetcher() { 37 ImageResourceFetcher::~ImageResourceFetcher() {
36 if (!fetcher_->completed()) 38 if (!fetcher_->completed())
37 fetcher_->Cancel(); 39 fetcher_->Cancel();
38 } 40 }
39 41
40 void ImageResourceFetcher::OnURLFetchComplete( 42 void ImageResourceFetcher::OnURLFetchComplete(
41 const WebURLResponse& response, 43 const WebURLResponse& response,
42 const std::string& data) { 44 const std::string& data) {
43 SkBitmap bitmap; 45 SkBitmap bitmap;
44 if (!response.isNull() && response.httpStatusCode() == 200) { 46 if (!response.isNull() && response.httpStatusCode() == 200) {
45 // Request succeeded, try to convert it to an image. 47 // Request succeeded, try to convert it to an image.
46 ImageDecoder decoder(gfx::Size(image_size_, image_size_)); 48 ImageDecoder decoder(gfx::Size(image_size_, image_size_));
47 bitmap = decoder.Decode( 49 bitmap = decoder.Decode(
48 reinterpret_cast<const unsigned char*>(data.data()), data.size()); 50 reinterpret_cast<const unsigned char*>(data.data()), data.size());
49 } // else case: 51 } // else case:
50 // If we get here, it means no image from server or couldn't decode the 52 // If we get here, it means no image from server or couldn't decode the
51 // response as an image. The delegate will see a null image, indicating 53 // response as an image. The delegate will see a null image, indicating
52 // that an error occurred. 54 // that an error occurred.
53 55
54 // Take care to clear callback_ before running the callback as it may lead to 56 // Take a reference to the callback as running the callback may lead to our
55 // our destruction. 57 // destruction.
56 scoped_ptr<Callback> callback; 58 Callback callback = callback_;
57 callback.swap(callback_); 59 callback.Run(this, bitmap);
58 callback->Run(this, bitmap);
59 } 60 }
60 61
61 } // namespace webkit_glue 62 } // namespace webkit_glue
OLDNEW
« no previous file with comments | « webkit/glue/image_resource_fetcher.h ('k') | webkit/glue/resource_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698