Issue 8550005: Put TCMalloc cleanup near the end of destructor list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8550005: Put TCMalloc cleanup near the end of destructor list (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years ago

Reviewers:
wtc, rvargas (doing something else)

CC:
chromium-reviews, wtc, willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Put TCMalloc cleanup near the end of destructor list Try to make sure that the destructor at thread termination for TCMalloc is called later than most any other destructors. If other destructors are called later, and if they use malloc, then TCMalloc will start a new instance, and never cleanup :-( r=rvargas BUG=103209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110987

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	third_party/tcmalloc/chromium/src/windows/port.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

http://codereview.chromium.org/8550005/diff/1/third_party/tcmalloc/chromium/src/windows/port.cc File third_party/tcmalloc/chromium/src/windows/port.cc (right): http://codereview.chromium.org/8550005/diff/1/third_party/tcmalloc/chromium/src/windows/port.cc#newcode158 third_party/tcmalloc/chromium/src/windows/port.cc:158: #pragma data_seg(".CRT$XLY") Just curious: why didn't you use CRT$XLZ?

9 years ago (2011-12-01 00:04:01 UTC) #3

rvargas (doing something else)

9 years ago (2011-12-01 01:22:34 UTC) #4

On 2011/12/01 00:04:01, wtc wrote:
>
http://codereview.chromium.org/8550005/diff/1/third_party/tcmalloc/chromium/s...
> File third_party/tcmalloc/chromium/src/windows/port.cc (right):
> 
>
http://codereview.chromium.org/8550005/diff/1/third_party/tcmalloc/chromium/s...
> third_party/tcmalloc/chromium/src/windows/port.cc:158: #pragma
> data_seg(".CRT$XLY")
> 
> Just curious: why didn't you use CRT$XLZ?

The CRT sets Z to NULL to guarantee a null terminated list of callbacks.

Expand Messages | Collapse Messages