Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 8550004: ASAN timeout on OutOfProcessPPAPITest.Crypto (Closed)

Created:
9 years, 1 month ago by dhollowa
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., kcc2
Visibility:
Public.

Description

ASAN timeout on OutOfProcessPPAPITest.Crypto Disables OutOfProcessPPAPITest.Crypto test on ASAN. BUG=104832 TEST=ASAN bot runs green TBR=dmichael@chromium.org, noelallen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110814

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +10 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
dhollowa
Timur, is there a better way to disable ASAN tests? I tried http://codereview.chromium.org/8603005 but that ...
9 years, 1 month ago (2011-11-19 02:01:26 UTC) #1
Timur Iskhodzhanov
AFAIK, no. Alexander has answered you on the other thread; Also I think he was ...
9 years, 1 month ago (2011-11-19 19:02:57 UTC) #2
Timur Iskhodzhanov
another PoV: a better way is to file a bug and disable the test unconditionally ...
9 years, 1 month ago (2011-11-19 19:04:00 UTC) #3
Alexander Potapenko
ASan defines the ADDRESS_SANITIZER macro, so you can check for it. We've also a test ...
9 years, 1 month ago (2011-11-19 19:06:59 UTC) #4
Nico
http://codereview.chromium.org/8550004/diff/1/chrome/test/ui/ppapi_uitest.cc File chrome/test/ui/ppapi_uitest.cc (right): http://codereview.chromium.org/8550004/diff/1/chrome/test/ui/ppapi_uitest.cc#newcode298 chrome/test/ui/ppapi_uitest.cc:298: TEST_F(OutOfProcessPPAPITest, Crypto) { Shouldn't this say MAYE_Crypto? (Apologies if ...
8 years, 8 months ago (2012-04-06 14:50:18 UTC) #5
Alexander Potapenko
8 years, 8 months ago (2012-04-06 14:53:32 UTC) #6
I think it should.
BTW, does this test run NaCl?

Powered by Google App Engine
This is Rietveld 408576698