Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3963)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 8550003: Defer construction of NotificationUIManager to fix notification initialization. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-enable pyauto test Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index ab2b807298bf7ffbff46d8103dc8639f3b0c8906..ac993ccad1f46202626aab130e62eaa4f8b3b740 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1852,11 +1852,6 @@ void ChromeBrowserMainParts::StartBrowserOrUITask() {
// Still initializing, so need to allow IO.
base::ThreadRestrictions::ScopedAllowIO allow_io;
- // Set the notification UI manager after any desktop initialization in
- // PreMainMessageLoopRun() is complete, and before starting the browser.
- DesktopNotificationServiceFactory::GetForProfile(profile_)->SetUIManager(
- g_browser_process->notification_ui_manager());
-
// Tests should be able to tune login manager before showing it.
// Thus only show login manager in normal (non-testing) mode.
if (!parameters().ui_task)
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698