runtime/lib/error.cc - Issue 8549033: Update comments in core lib showing proper factory syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/error.cc

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/error.cc

===================================================================

--- runtime/lib/error.cc (revision 1677)

+++ runtime/lib/error.cc (working copy)

@@ -142,7 +142,12 @@

// Type errors in the core library may be difficult to diagnose.

// Print type error information before throwing the error when debugging.

if (FLAG_print_stack_trace_at_throw) {

- OS::Print("Type %s is not assignable to type %s of %s.\n",

+ intptr_t line, column;

+ script.GetTokenLocation(location, &line, &column);

+ OS::Print("'%s': Failed type check: line %d pos %d: "

+ "type '%s' is not assignable to type '%s' of '%s'.\n",

+ String::Handle(script.url()).ToCString(),

+ line, column,

src_type_name.ToCString(),

dst_type_name.ToCString(),

dst_name.ToCString());

« no previous file with comments | « corelib/src/set.dart ('k') | runtime/lib/error.dart » ('j') | no next file with comments »