Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: corelib/src/set.dart

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: corelib/src/set.dart
===================================================================
--- corelib/src/set.dart (revision 1677)
+++ corelib/src/set.dart (working copy)
@@ -6,8 +6,9 @@
* This class is the public interface of a set. A set is a collection
* without duplicates.
*/
-interface Set<E> extends Collection<E> factory HashSetImplementation/* <E> */ {
-// Bug 5408808: Factory should be HashSetImplementation<E>
+interface Set<E> extends Collection<E>
+ factory HashSetImplementation/*<E extends Hashable>*/ {
+// See issue 417. Works in the vm, fails in dartc and frog.
Set();
/**
@@ -69,8 +70,8 @@
}
interface HashSet<E extends Hashable> extends Set<E>
- factory HashSetImplementation /* <E> */ {
-// Bug 5408808: Factory should be HashSetImplementation<E>
+ factory HashSetImplementation/*<E extends Hashable>*/ {
+// See issue 417. Works in the vm, fails in dartc and frog.
HashSet();
/**
« no previous file with comments | « corelib/src/map.dart ('k') | runtime/lib/error.cc » ('j') | tests/language/src/Factory3Test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698