Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: content/browser/browser_main_loop.h

Issue 8549027: Fix ProcessSingletonTest.StartupRaceCondition for win. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/browser_main_loop.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_ 5 #ifndef CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
6 #define CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_ 6 #define CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 int GetResultCode() const { return result_code_; } 46 int GetResultCode() const { return result_code_; }
47 47
48 private: 48 private:
49 void InitializeMainThread(); 49 void InitializeMainThread();
50 50
51 // Members initialized on construction --------------------------------------- 51 // Members initialized on construction ---------------------------------------
52 const content::MainFunctionParams& parameters_; 52 const content::MainFunctionParams& parameters_;
53 const CommandLine& parsed_command_line_; 53 const CommandLine& parsed_command_line_;
54 int result_code_; 54 int result_code_;
55 55
56 scoped_ptr<BrowserMainParts> parts_;
57
56 // Members initialized in |MainMessageLoopStart()| --------------------------- 58 // Members initialized in |MainMessageLoopStart()| ---------------------------
57 scoped_ptr<MessageLoop> main_message_loop_; 59 scoped_ptr<MessageLoop> main_message_loop_;
58 scoped_ptr<base::SystemMonitor> system_monitor_; 60 scoped_ptr<base::SystemMonitor> system_monitor_;
59 scoped_ptr<HighResolutionTimerManager> hi_res_timer_manager_; 61 scoped_ptr<HighResolutionTimerManager> hi_res_timer_manager_;
60 scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_; 62 scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_;
61 #if defined(OS_WIN) 63 #if defined(OS_WIN)
62 scoped_ptr<SystemMessageWindowWin> system_message_window_; 64 scoped_ptr<SystemMessageWindowWin> system_message_window_;
63 #endif 65 #endif
64
65 // Destroy parts_ before main_message_loop_ (required) and before other
66 // classes constructed in content (but after main_thread_).
67 scoped_ptr<BrowserMainParts> parts_;
68
69 // Members initialized in |InitializeMainThread()| ---------------------------
70 // This must get destroyed before other threads that are created in parts_.
71 scoped_ptr<BrowserThreadImpl> main_thread_; 66 scoped_ptr<BrowserThreadImpl> main_thread_;
72 67
73 DISALLOW_COPY_AND_ASSIGN(BrowserMainLoop); 68 DISALLOW_COPY_AND_ASSIGN(BrowserMainLoop);
74 }; 69 };
75 70
76 } // namespace content 71 } // namespace content
77 72
78 #endif // CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_ 73 #endif // CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_main_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698