wayland: integrate gl_surface_wayland.cc into gl_surface_linux.cc

wayland: integrate gl_surface_wayland.cc into gl_surface_linux.cc

BUG=102903
TEST=compile

Change-Id: I9334cd15458709b467ed768b8a89ff41c178ce34

R=backer@chromium.org,dnicoara@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111182

[jonathan.backer, 2011-11-18 18:59:29]

SGTM

I'm OK with this, but I'm adding apatrick@ so that he can have a say.

Now that pbuffers work with wayland, I see less of a need for
gl_surface_wayland.cc.  But we're really pot marking gl_surface_linux.cc --
which is something the gl_surface_wayland.cc prevented.

[Mandeep Singh Baines, 2011-11-21 17:25:30]

ping

[apatrick_chromium, 2011-11-21 20:05:59]

Sorry for the delay. Rather than making this a compile time switch, would it be
possible to effectively make --use-gl=egl be the default for wayland?

I've been trying to avoid platform specific ifdefs because it means people
working on other platforms don't have to wait for their change to reach a bot
before learning of errors.

Is there a bot that tests this code path?

[Mandeep Singh Baines, 2011-11-21 21:14:01]

On 2011/11/21 20:05:59, apatrick_chromium wrote:
> Sorry for the delay. Rather than making this a compile time switch, would it
be
> possible to effectively make --use-gl=egl be the default for wayland?
> 
> I've been trying to avoid platform specific ifdefs because it means people
> working on other platforms don't have to wait for their change to reach a bot
> before learning of errors.
> 

I need the ifdefs because I need to be able to compile wayland without X being
installed. use_wayland=1 will eventually imply use_x11=0 but I'm not totally
there yet. At that point, I'll convert the !USE_WAYLANDs to USE_X11.

We could avoid a lot of the ifdefs by giving each implementation a separate
file. That might be something to consider eventually.

I've been using the "Commit" button to commit my changes. That should make sure
most code paths get tested.

> Is there a bot that tests this code path?

Once I get a wayland build that compiles and runs, I'll setup a bot.

My current patch series (some not yet posted) compiles but doesn't link because
I haven't implemented desktop_host_wayland yet.

[apatrick_chromium, 2011-11-21 22:07:05]

lgtm

[commit-bot: I haz the power, 2011-11-22 17:00:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msb@chromium.org/8549024/1

[commit-bot: I haz the power, 2011-11-22 18:40:56]

Change committed as 111182