Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: chrome/browser/extensions/extension_debugger_api.cc

Issue 8549022: Define DevTools content API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DevToolsManager -> DevToolsManagerImpl, moved client to public Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_debugger_api.cc
diff --git a/chrome/browser/extensions/extension_debugger_api.cc b/chrome/browser/extensions/extension_debugger_api.cc
index d86f195c909172c07ef3a57183bde3d0efa45012..b4bb9382b09cc0a916cddd4b521a70b850bccd0f 100644
--- a/chrome/browser/extensions/extension_debugger_api.cc
+++ b/chrome/browser/extensions/extension_debugger_api.cc
@@ -22,13 +22,19 @@
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_error_utils.h"
-#include "content/browser/debugger/devtools_client_host.h"
-#include "content/browser/debugger/devtools_manager.h"
+#include "content/public/browser/devtools/devtools_agent_host_registry.h"
+#include "content/public/browser/devtools/devtools_client_host.h"
+#include "content/public/browser/devtools/devtools_manager.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/common/devtools_messages.h"
#include "content/public/browser/notification_source.h"
#include "webkit/glue/webkit_glue.h"
+using content::DevToolsAgentHost;
+using content::DevToolsAgentHostRegistry;
+using content::DevToolsClientHost;
+using content::DevToolsManager;
+
namespace keys = extension_debugger_api_constants;
class ExtensionDevToolsClientHost : public DevToolsClientHost,
@@ -98,8 +104,12 @@ class AttachedClientHosts {
}
ExtensionDevToolsClientHost* Lookup(RenderViewHost* rvh) {
+ if (!DevToolsAgentHostRegistry::HasDevToolsAgentHost(rvh))
+ return NULL;
+ DevToolsAgentHost* agent =
+ DevToolsAgentHostRegistry::GetDevToolsAgentHost(rvh);
DevToolsClientHost* client_host =
- DevToolsManager::GetInstance()->GetDevToolsClientHostFor(rvh);
+ DevToolsManager::GetInstance()->GetDevToolsClientHostFor(agent);
std::set<DevToolsClientHost*>::iterator it =
client_hosts_.find(client_host);
if (it == client_hosts_.end())
@@ -130,9 +140,9 @@ ExtensionDevToolsClientHost::ExtensionDevToolsClientHost(
content::Source<Profile>(profile));
// Attach to debugger and tell it we are ready.
- DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(
- tab_contents_->render_view_host(),
- this);
+ DevToolsAgentHost* agent = DevToolsAgentHostRegistry::GetDevToolsAgentHost(
+ tab_contents_->render_view_host());
+ DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(agent, this);
DevToolsManager::GetInstance()->ForwardToDevToolsAgent(
this,
DevToolsAgentMsg_FrontendLoaded(MSG_ROUTING_NONE));
@@ -317,8 +327,10 @@ bool AttachDebuggerFunction::RunImpl() {
return false;
}
+ DevToolsAgentHost* agent = DevToolsAgentHostRegistry::GetDevToolsAgentHost(
+ contents_->render_view_host());
DevToolsClientHost* client_host = DevToolsManager::GetInstance()->
- GetDevToolsClientHostFor(contents_->render_view_host());
+ GetDevToolsClientHostFor(agent);
if (client_host != NULL) {
error_ = ExtensionErrorUtils::FormatErrorMessage(

Powered by Google App Engine
This is Rietveld 408576698