Define DevTools content API

content/public/browser/devtools/devtools_client_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
-#define CONTENT_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
+#ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_DEVTOOLS_CLIENT_HOST_H_
+#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_DEVTOOLS_CLIENT_HOST_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "content/common/content_export.h"
 
 namespace IPC {
 class Message;
 }
 
 class RenderViewHost;
 class TabContents;
 
+namespace content {
+
 // Describes interface for managing devtools clients from browser process. There
 // are currently two types of clients: devtools windows and TCP socket
 // debuggers.
 class CONTENT_EXPORT DevToolsClientHost {
  public:
   class CONTENT_EXPORT CloseListener {
    public:
     CloseListener() {}
     virtual ~CloseListener() {}
     virtual void ClientHostClosing(DevToolsClientHost* host) = 0;
@@ skipping 19 matching lines @@
   void set_close_listener(CloseListener* listener) {
     close_listener_ = listener;
   }
 
   // Invoked when a tab is replaced by another tab. This is triggered by
   // TabStripModel::ReplaceTabContentsAt.
   virtual void TabReplaced(TabContents* new_tab) = 0;
 
   // Returns client (front-end) RenderViewHost implementation of this
   // client host if applicable. NULL otherwise.
   virtual RenderViewHost* GetClientRenderViewHost();

[jam, 2011/11/21 21:16:04]

we've been trying to make all the interfaces in content/public to consist of
only pure virtual functions. can you make this one as well?

[yurys, 2011/11/30 15:49:43]

Done.

 
  protected:
   DevToolsClientHost();
 
   void ForwardToDevToolsAgent(const IPC::Message& message);

[jam, 2011/11/21 21:16:04]

is this actually used by anyone? i couldn't find it in searching (but i could be
mistaken).

[yurys, 2011/11/30 15:49:43]

It is used only in DevToolsWindow::OnMessageReceived, inlined it there.

 
   // Should be called when the devtools client is going to die and this
   // DevToolsClientHost should not be used anymore.
   void NotifyCloseListener();

[jam, 2011/11/21 21:16:04]

this and close_listener: can they be taken out of the interface (and change
set_close_listener to a pure virtual SetCloseListener)? we want to avoid member
variables on interfaces. this is really a one liner (call an interface), and you
can have the embedder implementations call this function in almost the same
lines of code that it takes them to call this function, so it doesn't seem worth
it to keep this functionality in the interface.

[yurys, 2011/11/30 15:49:43]

Done. Removed the CloseListener, there is no much sense in having it as we
expose abstract devtools client host interface. Clients can notify
DevToolsManager directly when they are closing.

 
  private:
   CloseListener* close_listener_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsClientHost);

[jam, 2011/11/21 21:16:04]

nit: not needed

[yurys, 2011/11/30 15:49:43]

Done.

 };
 
-#endif  // CONTENT_BROWSER_DEBUGGER_DEVTOOLS_CLIENT_HOST_H_
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_DEVTOOLS_DEVTOOLS_CLIENT_HOST_H_