Issue 8549005: De-FLAKY/FAILS MediaUILayoutTest since mac's been fixed and views has been decommissioned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8549005: De-FLAKY/FAILS MediaUILayoutTest since mac's been fixed and views has been decommissioned. (Closed)

Created:
9 years, 1 month ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 1 month ago

Reviewers:
Chris Rogers

CC:
chromium-reviews, Paweł Hajdan Jr., ojan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

De-FLAKY/FAILS MediaUILayoutTest since mac's been fixed and views has been decommissioned. BUG=95274, 103832 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109840

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -11 lines)			Patch
	M	chrome/browser/media_uitest.cc	View		1 chunk	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

crogers: please review. ojan: FYI since you weighed in on removal of Views.

9 years, 1 month ago (2011-11-13 03:16:06 UTC) #1

Chris Rogers

LGTM for the OS_MACOSX part On 2011/11/13 03:16:06, Ami Fischman wrote: > crogers: please review. ...

9 years, 1 month ago (2011-11-13 19:25:40 UTC) #2

ojan

9 years, 1 month ago (2011-11-14 18:14:53 UTC) #4

LGTM. Thanks for cleaning this up.

On Sun, Nov 13, 2011 at 11:35 AM, <commit-bot@chromium.org> wrote:

> No LGTM from valid reviewers yet.
>
>
http://codereview.chromium.**org/8549005/<http://codereview.chromium.org/8549...
>

Expand Messages | Collapse Messages