Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: net/dns/async_host_resolver.cc

Issue 8549004: base::Bind: Convert HostResolver::Resolve. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/async_host_resolver.cc
diff --git a/net/dns/async_host_resolver.cc b/net/dns/async_host_resolver.cc
index 70c9277c3975d929108e8d8f5a53056351e6a4e1..40cd17314926f97b9687e7c72d55d2cdd5c3502e 100644
--- a/net/dns/async_host_resolver.cc
+++ b/net/dns/async_host_resolver.cc
@@ -86,7 +86,7 @@ class AsyncHostResolver::Request {
const BoundNetLog& request_net_log,
int id,
const HostResolver::RequestInfo& info,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
AddressList* addresses)
: resolver_(resolver),
source_net_log_(source_net_log),
@@ -105,7 +105,7 @@ class AsyncHostResolver::Request {
}
~Request() {
- if (callback_)
+ if (!callback_.is_null())
resolver_->OnCancel(this);
}
@@ -164,7 +164,7 @@ class AsyncHostResolver::Request {
// |addresses_| and in case of an unsuccessful synchronous completion, we
// do not touch |addresses_|.
void OnSyncComplete(int result) {
- callback_ = NULL;
+ callback_.Reset();
resolver_->OnFinish(this, result);
}
@@ -172,11 +172,11 @@ class AsyncHostResolver::Request {
void OnAsyncComplete(int result, const AddressList& addresses) {
if (result == OK)
*addresses_ = CreateAddressListUsingPort(addresses, info_.port());
- DCHECK(callback_);
- OldCompletionCallback* callback = callback_;
- callback_ = NULL;
+ DCHECK_EQ(false, callback_.is_null());
+ CompletionCallback callback = callback_;
+ callback_.Reset();
resolver_->OnFinish(this, result);
- callback->Run(result);
+ callback.Run(result);
}
// Returns true if request has a validly formed hostname.
@@ -191,7 +191,7 @@ class AsyncHostResolver::Request {
const int id_;
const HostResolver::RequestInfo info_;
Key key_;
- OldCompletionCallback* callback_;
+ CompletionCallback callback_;
AddressList* addresses_;
int result_;
};
@@ -230,11 +230,11 @@ AsyncHostResolver::~AsyncHostResolver() {
int AsyncHostResolver::Resolve(const RequestInfo& info,
AddressList* addresses,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
RequestHandle* out_req,
const BoundNetLog& source_net_log) {
DCHECK(addresses);
- DCHECK(callback);
+ DCHECK_EQ(false, callback.is_null());
scoped_ptr<Request> request(
CreateNewRequest(info, callback, addresses, source_net_log));
@@ -264,7 +264,7 @@ int AsyncHostResolver::ResolveFromCache(const RequestInfo& info,
AddressList* addresses,
const BoundNetLog& source_net_log) {
scoped_ptr<Request> request(
- CreateNewRequest(info, NULL, addresses, source_net_log));
+ CreateNewRequest(info, CompletionCallback(), addresses, source_net_log));
int rv = ERR_UNEXPECTED;
if (!request->IsValid())
rv = ERR_NAME_NOT_RESOLVED;
@@ -410,7 +410,7 @@ void AsyncHostResolver::OnTransactionComplete(
AsyncHostResolver::Request* AsyncHostResolver::CreateNewRequest(
const RequestInfo& info,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
AddressList* addresses,
const BoundNetLog& source_net_log) {
BoundNetLog request_net_log = BoundNetLog::Make(net_log_,

Powered by Google App Engine
This is Rietveld 408576698