Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Side by Side Diff: net/base/single_request_host_resolver_unittest.cc

Issue 8549004: base::Bind: Convert HostResolver::Resolve. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/single_request_host_resolver.h" 5 #include "net/base/single_request_host_resolver.h"
6 6
7 #include "net/base/address_list.h" 7 #include "net/base/address_list.h"
8 #include "net/base/mock_host_resolver.h" 8 #include "net/base/mock_host_resolver.h"
9 #include "net/base/net_errors.h" 9 #include "net/base/net_errors.h"
10 #include "net/base/net_log.h" 10 #include "net/base/net_log.h"
(...skipping 14 matching lines...) Expand all
25 virtual ~HangingHostResolver() { 25 virtual ~HangingHostResolver() {
26 EXPECT_TRUE(!has_outstanding_request()); 26 EXPECT_TRUE(!has_outstanding_request());
27 } 27 }
28 28
29 bool has_outstanding_request() const { 29 bool has_outstanding_request() const {
30 return outstanding_request_ != NULL; 30 return outstanding_request_ != NULL;
31 } 31 }
32 32
33 virtual int Resolve(const RequestInfo& info, 33 virtual int Resolve(const RequestInfo& info,
34 AddressList* addresses, 34 AddressList* addresses,
35 OldCompletionCallback* callback, 35 const CompletionCallback& callback,
36 RequestHandle* out_req, 36 RequestHandle* out_req,
37 const BoundNetLog& net_log) OVERRIDE { 37 const BoundNetLog& net_log) OVERRIDE {
38 EXPECT_FALSE(has_outstanding_request()); 38 EXPECT_FALSE(has_outstanding_request());
39 outstanding_request_ = reinterpret_cast<RequestHandle>(0x1234); 39 outstanding_request_ = reinterpret_cast<RequestHandle>(0x1234);
40 *out_req = outstanding_request_; 40 *out_req = outstanding_request_;
41 41
42 // Never complete this request! Caller is expected to cancel it 42 // Never complete this request! Caller is expected to cancel it
43 // before destroying the resolver. 43 // before destroying the resolver.
44 return ERR_IO_PENDING; 44 return ERR_IO_PENDING;
45 } 45 }
(...skipping 29 matching lines...) Expand all
75 TEST(SingleRequestHostResolverTest, NormalResolve) { 75 TEST(SingleRequestHostResolverTest, NormalResolve) {
76 // Create a host resolver dependency that returns address "199.188.1.166" 76 // Create a host resolver dependency that returns address "199.188.1.166"
77 // for resolutions of "watsup". 77 // for resolutions of "watsup".
78 MockHostResolver resolver; 78 MockHostResolver resolver;
79 resolver.rules()->AddIPLiteralRule("watsup", "199.188.1.166", ""); 79 resolver.rules()->AddIPLiteralRule("watsup", "199.188.1.166", "");
80 80
81 SingleRequestHostResolver single_request_resolver(&resolver); 81 SingleRequestHostResolver single_request_resolver(&resolver);
82 82
83 // Resolve "watsup:90" using our SingleRequestHostResolver. 83 // Resolve "watsup:90" using our SingleRequestHostResolver.
84 AddressList addrlist; 84 AddressList addrlist;
85 TestOldCompletionCallback callback; 85 TestCompletionCallback callback;
86 HostResolver::RequestInfo request(HostPortPair("watsup", 90)); 86 HostResolver::RequestInfo request(HostPortPair("watsup", 90));
87 int rv = single_request_resolver.Resolve( 87 int rv = single_request_resolver.Resolve(
88 request, &addrlist, &callback, BoundNetLog()); 88 request, &addrlist, callback.callback(), BoundNetLog());
89 EXPECT_EQ(ERR_IO_PENDING, rv); 89 EXPECT_EQ(ERR_IO_PENDING, rv);
90 EXPECT_EQ(OK, callback.WaitForResult()); 90 EXPECT_EQ(OK, callback.WaitForResult());
91 91
92 // Verify that the result is what we specified in the MockHostResolver. 92 // Verify that the result is what we specified in the MockHostResolver.
93 EXPECT_EQ("199.188.1.166", NetAddressToString(addrlist.head())); 93 EXPECT_EQ("199.188.1.166", NetAddressToString(addrlist.head()));
94 } 94 }
95 95
96 // Test that the Cancel() method cancels any outstanding request. 96 // Test that the Cancel() method cancels any outstanding request.
97 TEST(SingleRequestHostResolverTest, Cancel) { 97 TEST(SingleRequestHostResolverTest, Cancel) {
98 HangingHostResolver resolver; 98 HangingHostResolver resolver;
99 99
100 { 100 {
101 SingleRequestHostResolver single_request_resolver(&resolver); 101 SingleRequestHostResolver single_request_resolver(&resolver);
102 102
103 // Resolve "watsup:90" using our SingleRequestHostResolver. 103 // Resolve "watsup:90" using our SingleRequestHostResolver.
104 AddressList addrlist; 104 AddressList addrlist;
105 TestOldCompletionCallback callback; 105 TestCompletionCallback callback;
106 HostResolver::RequestInfo request(HostPortPair("watsup", 90)); 106 HostResolver::RequestInfo request(HostPortPair("watsup", 90));
107 int rv = single_request_resolver.Resolve( 107 int rv = single_request_resolver.Resolve(
108 request, &addrlist, &callback, BoundNetLog()); 108 request, &addrlist, callback.callback(), BoundNetLog());
109 EXPECT_EQ(ERR_IO_PENDING, rv); 109 EXPECT_EQ(ERR_IO_PENDING, rv);
110 EXPECT_TRUE(resolver.has_outstanding_request()); 110 EXPECT_TRUE(resolver.has_outstanding_request());
111 } 111 }
112 112
113 // Now that the SingleRequestHostResolver has been destroyed, the 113 // Now that the SingleRequestHostResolver has been destroyed, the
114 // in-progress request should have been aborted. 114 // in-progress request should have been aborted.
115 EXPECT_FALSE(resolver.has_outstanding_request()); 115 EXPECT_FALSE(resolver.has_outstanding_request());
116 } 116 }
117 117
118 // Test that the Cancel() method is a no-op when there is no outstanding 118 // Test that the Cancel() method is a no-op when there is no outstanding
119 // request. 119 // request.
120 TEST(SingleRequestHostResolverTest, CancelWhileNoPendingRequest) { 120 TEST(SingleRequestHostResolverTest, CancelWhileNoPendingRequest) {
121 HangingHostResolver resolver; 121 HangingHostResolver resolver;
122 SingleRequestHostResolver single_request_resolver(&resolver); 122 SingleRequestHostResolver single_request_resolver(&resolver);
123 single_request_resolver.Cancel(); 123 single_request_resolver.Cancel();
124 124
125 // To pass, HangingHostResolver should not have received a cancellation 125 // To pass, HangingHostResolver should not have received a cancellation
126 // request (since there is nothing to cancel). If it does, it will crash. 126 // request (since there is nothing to cancel). If it does, it will crash.
127 } 127 }
128 128
129 } // namespace 129 } // namespace
130 130
131 } // namespace net 131 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698