Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: client/html/src/NodeWrappingImplementation.dart

Issue 8548019: Add a script for determining which DOM methods correspond to which HTML methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More code review changes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/html/src/NodeWrappingImplementation.dart
diff --git a/client/html/src/NodeWrappingImplementation.dart b/client/html/src/NodeWrappingImplementation.dart
index 81c4a4a4d809caf2a1a217aedfeda046936785ea..79ae11997ab1180d597a58cc6a077bbcb7695352 100644
--- a/client/html/src/NodeWrappingImplementation.dart
+++ b/client/html/src/NodeWrappingImplementation.dart
@@ -57,6 +57,7 @@ class _ChildrenNodeList implements NodeList {
return false;
}
+ /** @domName Node.hasChildNodes */
Jacob 2011/11/21 23:12:11 isEmpty should be return !_nod.hasChildNodes();
nweiz 2011/11/22 01:11:09 Done.
bool isEmpty() {
return _node.hasChildNodes();
}
@@ -77,6 +78,7 @@ class _ChildrenNodeList implements NodeList {
throw new UnsupportedOperationException('');
}
+ /** @domName Node.appendChild */
Node add(Node value) {
_node.appendChild(LevelDom.unwrap(value));
return value;
@@ -196,6 +198,7 @@ class NodeWrappingImplementation extends EventTargetWrappingImplementation imple
return this;
}
+ /** @domName Node.contains */
Jacob 2011/11/21 23:12:11 should be Element.contains
nweiz 2011/11/22 01:11:09 Element.contains doesn't exist in the DOM API.
bool contains(Node otherNode) {
// TODO: Feature detect and use built in.
while (otherNode != null && otherNode != this) {

Powered by Google App Engine
This is Rietveld 408576698