Issue 8548014: Get rid of last gpu_messages.h dependency in chrome by having chrome ask the GPUProcessHostUIShim...

Issue 8548014: Get rid of last gpu_messages.h dependency in chrome by having chrome ask the GPUProcessHostUIShim... (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
Vangelis Kokkevis, apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get rid of last gpu_messages.h dependency in chrome by having chrome ask the GPUProcessHostUIShim to hang/crash/clean the gpu process. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110802

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : fix shared #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -12 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View	1	2 chunks	+10 lines, -8 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host_ui_shim.h	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	content/browser/gpu/gpu_process_host_ui_shim.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/common/gpu/gpu_process_launch_causes.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

Approach is fine. When the trybots pass LGTM. http://codereview.chromium.org/8548014/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): http://codereview.chromium.org/8548014/diff/1/chrome/browser/browser_about_handler.cc#newcode1564 chrome/browser/browser_about_handler.cc:1564: shim->SimulateClean(); ...

9 years, 1 month ago (2011-11-18 17:53:29 UTC) #2

jam

http://codereview.chromium.org/8548014/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): http://codereview.chromium.org/8548014/diff/1/chrome/browser/browser_about_handler.cc#newcode1564 chrome/browser/browser_about_handler.cc:1564: shim->SimulateClean(); On 2011/11/18 17:53:30, apatrick_chromium wrote: > I think ...

9 years, 1 month ago (2011-11-18 17:57:26 UTC) #3

LGTM

Expand Messages | Collapse Messages