Moving experimental.metrics API to metricsPrivate

Moving experimental.metrics API to metricsPrivate

1. experimental.metrics is now metricsPrivate
2. metricsPrivate is available to component extensions only
3. removed getEnabled/setEnabled functions as useless/harmful.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111136

[Vladislav Kaznacheev, 2011-11-18 13:41:13]

Hi Roger,

Please take a look. This should take care of the security concerns we discussed
earlier.

Best regards,

  Vlad

[Roger Tawa OOO till Jul 10th, 2011-11-18 21:48:44]

lgtm

Cool, didn't know we could restrict apis to components only.

A few nits below.

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/metrics/manifest.json (right):

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/metrics/manifest.json:5: "description":
"end-to-end browser test for chrome.metrics API",
rename metrics --> metricsPrivate ?

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/metrics/test.js (right):

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/metrics/test.js:50: 42 * 1000 * 60);
alignment should be fixed

[Vladislav Kaznacheev, 2011-11-21 10:40:14]

Thanks for the review, committing.

  Vlad

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/metrics/manifest.json (right):

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/metrics/manifest.json:5: "description":
"end-to-end browser test for chrome.metrics API",
On 2011/11/18 21:48:44, Roger Tawa wrote:
> rename metrics --> metricsPrivate ?

Done.

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
File chrome/test/data/extensions/api_test/metrics/test.js (right):

http://codereview.chromium.org/8548013/diff/1/chrome/test/data/extensions/api...
chrome/test/data/extensions/api_test/metrics/test.js:50: 42 * 1000 * 60);
On 2011/11/18 21:48:44, Roger Tawa wrote:
> alignment should be fixed

Done.

[commit-bot: I haz the power, 2011-11-21 10:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8548013/6001

[commit-bot: I haz the power, 2011-11-21 10:40:31]

Presubmit check for 8548013-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/common/extensions/api/extension_api.json

Presubmit checks took 1.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Vladislav Kaznacheev, 2011-11-21 11:01:43]

Matt, Mihai,

extensions_api.json has quite a few owners, but you seem to have reviewed the
most recent changes. May I ask you to take a look at this patch?

Thanks,

  Vlad

[Aaron Boodman, 2011-11-22 09:46:03]

lgtm

[commit-bot: I haz the power, 2011-11-22 09:46:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8548013/6001

[commit-bot: I haz the power, 2011-11-22 09:46:58]

Can't apply patch for file chrome/browser/extensions/extension_metrics_module.h.
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/extension_metrics_module.h
Hunk #1 FAILED at 11.
Hunk #2 FAILED at 38.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/extensions/extension_metrics_module.h.rej

[commit-bot: I haz the power, 2011-11-22 10:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8548013/12001

[commit-bot: I haz the power, 2011-11-22 12:02:09]

Change committed as 111136