Issue 8548012: Added "select all/none" checkbox.

Issue 8548012: Added "select all/none" checkbox. (Closed)

Created:
9 years, 1 month ago by SeRya

Modified:
9 years, 1 month ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, nkostylev+watch_chromium.org, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added "select all/none" checkbox. BUG=chromium-os:20156 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110943

Patch Set 1 #

Patch Set 2 : Remove debuggin code #

Total comments: 4

Patch Set 3 : Merge #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -9 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	4 chunks	+41 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/array_data_model.js	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/table/table_column.js	View		4 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/table/table_column_model.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/table/table_header.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

http://codereview.chromium.org/8548012/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/8548012/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js#newcode3206 chrome/browser/resources/file_manager/js/file_manager.js:3206: chrome.fileBrowserPrivate.removeFileWatch(this.currentDirEntry_.toURL(), This change is already committed by jamescook http://codereview.chromium.org/8548012/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js#newcode3217 ...

9 years, 1 month ago (2011-11-21 13:14:49 UTC) #2

SeRya

http://codereview.chromium.org/8548012/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/8548012/diff/1001/chrome/browser/resources/file_manager/js/file_manager.js#newcode3206 chrome/browser/resources/file_manager/js/file_manager.js:3206: chrome.fileBrowserPrivate.removeFileWatch(this.currentDirEntry_.toURL(), On 2011/11/21 13:14:50, Vladislav Kaznacheev wrote: > This ...

9 years, 1 month ago (2011-11-21 14:19:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/8548012/3010

9 years, 1 month ago (2011-11-21 15:17:03 UTC) #5

Change committed as 110943

Expand Messages | Collapse Messages