Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: chrome/browser/chromeos/dbus/cros_disks_client.cc

Issue 8548011: Use cros-disks signal name constants defined in system_api/dbus/service_constants.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/dbus/cros_disks_client.h" 5 #include "chrome/browser/chromeos/dbus/cros_disks_client.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "chrome/browser/chromeos/system/runtime_environment.h" 9 #include "chrome/browser/chromeos/system/runtime_environment.h"
10 #include "dbus/bus.h" 10 #include "dbus/bus.h"
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 device_path, 167 device_path,
168 callback, 168 callback,
169 error_callback)); 169 error_callback));
170 } 170 }
171 171
172 // CrosDisksClient override. 172 // CrosDisksClient override.
173 virtual void SetUpConnections( 173 virtual void SetUpConnections(
174 MountEventHandler mount_event_handler, 174 MountEventHandler mount_event_handler,
175 MountCompletedHandler mount_completed_handler) OVERRIDE { 175 MountCompletedHandler mount_completed_handler) OVERRIDE {
176 static const SignalEventTuple kSignalEventTuples[] = { 176 static const SignalEventTuple kSignalEventTuples[] = {
177 { "DeviceAdded", DEVICE_ADDED }, 177 { cros_disks::kDeviceAdded, DEVICE_ADDED },
178 { "DeviceScanned", DEVICE_SCANNED }, 178 { cros_disks::kDeviceScanned, DEVICE_SCANNED },
179 { "DeviceRemoved", DEVICE_REMOVED }, 179 { cros_disks::kDeviceRemoved, DEVICE_REMOVED },
180 { "DiskAdded", DISK_ADDED }, 180 { cros_disks::kDiskAdded, DISK_ADDED },
181 { "DiskChanged", DISK_CHANGED }, 181 { cros_disks::kDiskChanged, DISK_CHANGED },
182 { "DiskRemoved", DISK_REMOVED }, 182 { cros_disks::kDiskRemoved, DISK_REMOVED },
183 { "FormattingFinished", FORMATTING_FINISHED }, 183 { cros_disks::kFormattingFinished, FORMATTING_FINISHED },
184 }; 184 };
185 const size_t kNumSignalEventTuples = arraysize(kSignalEventTuples); 185 const size_t kNumSignalEventTuples = arraysize(kSignalEventTuples);
186 186
187 for (size_t i = 0; i < kNumSignalEventTuples; ++i) { 187 for (size_t i = 0; i < kNumSignalEventTuples; ++i) {
188 proxy_->ConnectToSignal( 188 proxy_->ConnectToSignal(
189 cros_disks::kCrosDisksInterface, 189 cros_disks::kCrosDisksInterface,
190 kSignalEventTuples[i].signal_name, 190 kSignalEventTuples[i].signal_name,
191 base::Bind(&CrosDisksClientImpl::OnMountEvent, 191 base::Bind(&CrosDisksClientImpl::OnMountEvent,
192 weak_ptr_factory_.GetWeakPtr(), 192 weak_ptr_factory_.GetWeakPtr(),
193 kSignalEventTuples[i].event_type, 193 kSignalEventTuples[i].event_type,
194 mount_event_handler), 194 mount_event_handler),
195 base::Bind(&CrosDisksClientImpl::OnSignalConnected, 195 base::Bind(&CrosDisksClientImpl::OnSignalConnected,
196 weak_ptr_factory_.GetWeakPtr())); 196 weak_ptr_factory_.GetWeakPtr()));
197 } 197 }
198 proxy_->ConnectToSignal( 198 proxy_->ConnectToSignal(
199 cros_disks::kCrosDisksInterface, 199 cros_disks::kCrosDisksInterface,
200 "MountCompleted", 200 cros_disks::kMountCompleted,
201 base::Bind(&CrosDisksClientImpl::OnMountCompleted, 201 base::Bind(&CrosDisksClientImpl::OnMountCompleted,
202 weak_ptr_factory_.GetWeakPtr(), 202 weak_ptr_factory_.GetWeakPtr(),
203 mount_completed_handler ), 203 mount_completed_handler ),
204 base::Bind(&CrosDisksClientImpl::OnSignalConnected, 204 base::Bind(&CrosDisksClientImpl::OnSignalConnected,
205 weak_ptr_factory_.GetWeakPtr())); 205 weak_ptr_factory_.GetWeakPtr()));
206 } 206 }
207 207
208 private: 208 private:
209 // A struct to contain a pair of signal name and mount event type. 209 // A struct to contain a pair of signal name and mount event type.
210 // Used by SetUpConnections. 210 // Used by SetUpConnections.
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 526
527 // static 527 // static
528 CrosDisksClient* CrosDisksClient::Create(dbus::Bus* bus) { 528 CrosDisksClient* CrosDisksClient::Create(dbus::Bus* bus) {
529 if (system::runtime_environment::IsRunningOnChromeOS()) 529 if (system::runtime_environment::IsRunningOnChromeOS())
530 return new CrosDisksClientImpl(bus); 530 return new CrosDisksClientImpl(bus);
531 else 531 else
532 return new CrosDisksClientStubImpl(); 532 return new CrosDisksClientStubImpl();
533 } 533 }
534 534
535 } // namespace chromeos 535 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698