Issue 8548005: Adjust interfaces to indicate when tracking is in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8548005: Adjust interfaces to indicate when tracking is in progress (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, Paweł Hajdan Jr., sadrul, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adjust interfaces to indicate when tracking is in progress This should have no change whatever in function, but simply changes the names of calls for tracking time so that the ThreadData can know if a new trackig has started or ended. This will be helpful in (a future CL) measuring when the thread is doing something that is not tracked at all (e.g., processing UI events, etc.) r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109846

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -12 lines)			Patch
M	base/message_loop.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/profiler/scoped_profile.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/profiler/tracked_time_unittest.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/threading/worker_pool_posix.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/threading/worker_pool_win.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/tracked_objects.h	View	1 2 3	5 chunks	+11 lines, -4 lines	0 comments	Download
M	base/tracked_objects.cc	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

lgtm http://codereview.chromium.org/8548005/diff/5002/base/tracked_objects.h File base/tracked_objects.h (right): http://codereview.chromium.org/8548005/diff/5002/base/tracked_objects.h#newcode666 base/tracked_objects.h:666: // run. They are super fast when tracking ...

9 years, 1 month ago (2011-11-14 04:41:58 UTC) #2

jar (doing other things)

9 years, 1 month ago (2011-11-14 05:04:50 UTC) #3

change per comment by rtenneti

http://codereview.chromium.org/8548005/diff/5002/base/tracked_objects.h
File base/tracked_objects.h (right):

http://codereview.chromium.org/8548005/diff/5002/base/tracked_objects.h#newco...
base/tracked_objects.h:666: // run.  They are super fast when tracking is
disabled, and have some interal
On 2011/11/14 04:41:58, ramant wrote:
> nit: interal -> internal

Done.

Expand Messages | Collapse Messages