Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 8548003: Some easy NewRunnableMethod conversions in safe_browsing. (Closed)

Created:
9 years, 1 month ago by Scott Hess - ex-Googler
Modified:
9 years, 1 month ago
Reviewers:
awong
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Some easy NewRunnableMethod conversions in safe_browsing. Also a harder one of a CancelableTask timeout task, which was replaced with a callback-owned flag. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110166

Patch Set 1 #

Total comments: 2

Patch Set 2 : Convert to WeakPtrFactory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -66 lines) Patch
M chrome/browser/safe_browsing/protocol_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 26 chunks +43 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Scott Hess - ex-Googler
Mostly mundane conversions, except for the timeout_task conversion, which is why I posted it your ...
9 years, 1 month ago (2011-11-13 00:33:28 UTC) #1
awong
comment inline. http://codereview.chromium.org/8548003/diff/1/chrome/browser/safe_browsing/safe_browsing_service.h File chrome/browser/safe_browsing/safe_browsing_service.h (right): http://codereview.chromium.org/8548003/diff/1/chrome/browser/safe_browsing/safe_browsing_service.h#newcode109 chrome/browser/safe_browsing/safe_browsing_service.h:109: // will not fire. Wow. complicated. So ...
9 years, 1 month ago (2011-11-14 20:13:37 UTC) #2
Scott Hess - ex-Googler
http://codereview.chromium.org/8548003/diff/1/chrome/browser/safe_browsing/safe_browsing_service.h File chrome/browser/safe_browsing/safe_browsing_service.h (right): http://codereview.chromium.org/8548003/diff/1/chrome/browser/safe_browsing/safe_browsing_service.h#newcode109 chrome/browser/safe_browsing/safe_browsing_service.h:109: // will not fire. On 2011/11/14 20:13:37, awong wrote: ...
9 years, 1 month ago (2011-11-14 23:21:54 UTC) #3
awong
LGTM On 2011/11/14 23:21:54, shess wrote: > http://codereview.chromium.org/8548003/diff/1/chrome/browser/safe_browsing/safe_browsing_service.h > File chrome/browser/safe_browsing/safe_browsing_service.h (right): > > http://codereview.chromium.org/8548003/diff/1/chrome/browser/safe_browsing/safe_browsing_service.h#newcode109 ...
9 years, 1 month ago (2011-11-15 00:30:37 UTC) #4
Scott Hess - ex-Googler
The Linux trybot failure seems consistent for earlier and later numbered tries which do not ...
9 years, 1 month ago (2011-11-15 18:55:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/8548003/5001
9 years, 1 month ago (2011-11-15 18:55:54 UTC) #6
Scott Hess - ex-Googler
On 2011/11/15 00:30:37, awong wrote: > LGTM Thanks. > On 2011/11/14 23:21:54, shess wrote: > ...
9 years, 1 month ago (2011-11-15 18:58:15 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 21:17:21 UTC) #8
Change committed as 110166

Powered by Google App Engine
This is Rietveld 408576698