Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 8547017: Use WebUI version of SSL cert dialog on ChromeOS. (Closed)

Created:
9 years, 1 month ago by Rick Byers
Modified:
9 years, 1 month ago
Reviewers:
flackr
CC:
chromium-reviews, kevers, wtc, mattm
Visibility:
Public.

Description

Use WebUI version of SSL cert dialog on ChromeOS. Automated tests for this dialog are pending in crbug.com/104164. BUG=98027 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/webui/ssl_client_certificate_selector_webui.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Rick Byers
Rob, can you please review this tiny change?
9 years, 1 month ago (2011-11-22 14:22:17 UTC) #1
flackr
lgtm
9 years, 1 month ago (2011-11-22 14:48:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/8547017/1
9 years, 1 month ago (2011-11-22 15:11:40 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 16:11:59 UTC) #4
Change committed as 111163

Powered by Google App Engine
This is Rietveld 408576698