Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 8547006: Temporarily disable two tests in WidgetOwnershipTest on linux_chromeos build. (Closed)

Created:
9 years, 1 month ago by mazda
Modified:
9 years, 1 month ago
CC:
chromium-reviews, tfarina, dhollowa, Paweł Hajdan Jr.
Visibility:
Public.

Description

Temporarily disable two tests in WidgetOwnershipTest on linux_chromeos build. WidgetOwnershipTest.Ownership_ViewsNativeWidgetOwnsWidget WidgetOwnershipTest.Ownership_ViewsNativeWidgetOwnsWidget_NativeDestroy TBR=ben@chromium.org BUG=104945 TEST=views_unittests passed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M views/widget/widget_unittest.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mazda
9 years, 1 month ago (2011-11-21 08:54:27 UTC) #1
Ben Goodger (Google)
9 years, 1 month ago (2011-11-21 16:43:39 UTC) #2
LGTM

On Mon, Nov 21, 2011 at 12:54 AM, <mazda@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Temporarily disable two tests in WidgetOwnershipTest on linux_chromeos
> build.
>
> WidgetOwnershipTest.Ownership_**ViewsNativeWidgetOwnsWidget
> WidgetOwnershipTest.Ownership_**ViewsNativeWidgetOwnsWidget_**
> NativeDestroy
>
> TBR=ben@chromium.org
> BUG=104945
> TEST=views_unittests passed
>
> Committed: http://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=110891<http://src.chromium.org/viewvc/chrome?view=rev&revision=110891>
>
> Please review this at
http://codereview.chromium.**org/8547006/<http://codereview.chromium.org/8547...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M views/widget/widget_unittest.**cc
>
>
> Index: views/widget/widget_unittest.**cc
> diff --git a/views/widget/widget_**unittest.cc b/views/widget/widget_**
> unittest.cc
> index 736d6999a41003c58a85b8a1b8b50a**7e7e01fcb8..**
> 580bed8524eef4cbcbef4be5f45cd2**8cc8078ca1 100644
> --- a/views/widget/widget_**unittest.cc
> +++ b/views/widget/widget_**unittest.cc
> @@ -554,7 +554,12 @@ TEST_F(WidgetOwnershipTest, Ownership_**
> PlatformNativeWidgetOwnsWidget**) {
>  }
>
>  // NativeWidget owns its Widget, part 2: NativeWidget is a NativeWidget.
> +#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
> +// Temporarily disable the test (http://crbug.com/104945).
> +TEST_F(WidgetOwnershipTest, DISABLED_Ownership_**ViewsNativeWidgetOwnsWidget)
> {
> +#else
>  TEST_F(WidgetOwnershipTest, Ownership_**ViewsNativeWidgetOwnsWidget) {
> +#endif
>   OwnershipTestState state;
>
>   Widget* toplevel = CreateTopLevelPlatformWidget()**;
> @@ -604,8 +609,14 @@ TEST_F(WidgetOwnershipTest,
>
>  // NativeWidget owns its Widget, part 4: NativeWidget is a NativeWidget,
>  // destroyed by the view hierarchy that contains it.
> +#if defined(OS_CHROMEOS) && defined(TOOLKIT_USES_GTK)
> +// Temporarily disable the test (http://crbug.com/104945).
> +TEST_F(WidgetOwnershipTest,
> +       DISABLED_Ownership_**ViewsNativeWidgetOwnsWidget_**NativeDestroy)
> {
> +#else
>  TEST_F(WidgetOwnershipTest,
>        Ownership_**ViewsNativeWidgetOwnsWidget_**NativeDestroy) {
> +#endif
>   OwnershipTestState state;
>
>   Widget* toplevel = CreateTopLevelPlatformWidget()**;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698