Issue 8543002: Remove fake context support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8543002: Remove fake context support. (Closed)

Created:
9 years, 1 month ago by Yusuke Sato

Modified:
9 years, 1 month ago

Reviewers:
Peng

CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove fake context support. The fake context support in views::InputMethodIBus is no longer necessary because on Chrome OS, all input method hot keys are now handled inside Chrome. On Linux, views::InputMethodIBus might be used in the future, but it will also be okay because on the OS, the panel process for IBus, /usr/share/ibus/ui/gtk/main.py, will handle all input method hot keys. BUG=chromium-os:22905 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109842

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -94 lines)			Patch
	M	views/ime/input_method_ibus.h	View		5 chunks	+2 lines, -14 lines	0 comments	Download
	M	views/ime/input_method_ibus.cc	View		12 chunks	+12 lines, -80 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

9 years, 1 month ago (2011-11-14 01:51:49 UTC) #4

On 2011/11/14 01:49:22, I haz the power (commit-bot) wrote:
> No LGTM from valid reviewers yet.

hmm.. weird. Peng should already be a Chromium committer. I'll submit the change
manually for now.

Expand Messages | Collapse Messages