Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8543001: move chrome/browser/ui/gtk/certificate_viewer.* to chrome/browser/ui, add it to (Closed)

Created:
9 years, 1 month ago by benrg
Modified:
9 years, 1 month ago
Reviewers:
oshima, sky
CC:
chromium-reviews
Visibility:
Public.

Description

move chrome/browser/ui/gtk/certificate_viewer.* to chrome/browser/ui, add it to the aura build, and delete the stubs (which were ifdef'd out in Windows) BUG=102946 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110364

Patch Set 1 #

Total comments: 2

Patch Set 2 : delete extra lines in .gypi and update to latest tree #

Total comments: 1

Patch Set 3 : sort and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -250 lines) Patch
A + chrome/browser/ui/certificate_dialogs.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/certificate_dialogs.cc View 1 chunk +1 line, -3 lines 0 comments Download
D chrome/browser/ui/gtk/certificate_dialogs.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/gtk/certificate_dialogs.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M chrome/browser/ui/gtk/certificate_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/stubs_aura.cc View 1 2 2 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 5 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
http://codereview.chromium.org/8543001/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/8543001/diff/1/chrome/chrome_browser.gypi#newcode4165 chrome/chrome_browser.gypi:4165: ['include', '^browser/ui/certificate_dialogs.h'], Do you need this? Looks like this ...
9 years, 1 month ago (2011-11-14 23:11:40 UTC) #1
benrg
http://codereview.chromium.org/8543001/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/8543001/diff/1/chrome/chrome_browser.gypi#newcode4165 chrome/chrome_browser.gypi:4165: ['include', '^browser/ui/certificate_dialogs.h'], You're right.
9 years, 1 month ago (2011-11-15 00:26:15 UTC) #2
oshima
LGTM You need LGTM from owners as well.
9 years, 1 month ago (2011-11-15 15:34:25 UTC) #3
sky
LGTM http://codereview.chromium.org/8543001/diff/4001/chrome/browser/ui/webui/options/certificate_manager_handler.cc File chrome/browser/ui/webui/options/certificate_manager_handler.cc (right): http://codereview.chromium.org/8543001/diff/4001/chrome/browser/ui/webui/options/certificate_manager_handler.cc#newcode17 chrome/browser/ui/webui/options/certificate_manager_handler.cc:17: #include "chrome/browser/ui/certificate_dialogs.h" sort
9 years, 1 month ago (2011-11-15 20:33:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/8543001/11001
9 years, 1 month ago (2011-11-16 20:39:34 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 22:22:02 UTC) #6
Change committed as 110364

Powered by Google App Engine
This is Rietveld 408576698