[cros] Initial user image loading and repeated profile image loading fixes.

chrome/browser/chromeos/login/profile_image_downloader.h

Index: chrome/browser/chromeos/login/profile_image_downloader.h
diff --git a/chrome/browser/chromeos/login/profile_image_downloader.h b/chrome/browser/chromeos/login/profile_image_downloader.h
index 2a9f9094dfc944d4cc3a878b13639f1f1a8aa410..ead680ee2b0d82380300e911f5d5a0000f34570f 100644
--- a/chrome/browser/chromeos/login/profile_image_downloader.h
+++ b/chrome/browser/chromeos/login/profile_image_downloader.h
@@ -34,7 +34,8 @@ class ProfileImageDownloader : public content::URLFetcherDelegate,
     kDownloadResultsCount
   };
 
-  // Reports on success or failure of Profile image download.
+  // Reports on success or failure of Profile image download. The
+  // |ProfileImageDownloader| instance may be deleted in any of these handlers.

[whywhat, 2011/11/11 15:40:42]

May or should be?

[Ivan Korotkov, 2011/11/11 16:08:00]

Rephrased.

   class Delegate {
    public:
     virtual ~Delegate() {}
@@ -55,7 +56,7 @@ class ProfileImageDownloader : public content::URLFetcherDelegate,
 
   // Starts downloading the picture if the necessary authorization token is
   // ready. If not, subscribes to token service and starts fetching if the
-  // token is available.
+  // token is available. Should not be called more than once.

[whywhat, 2011/11/11 15:40:42]

Can't we call Start in ctor so we can't call it more than once on compiler
level?

[Ivan Korotkov, 2011/11/11 16:08:00]

I'd prefer to be consistent with most other loaders that don't start any work
immediately upon creation.

   void Start();
 
  private: