[cros] Initial user image loading and repeated profile image loading fixes.

chrome/browser/chromeos/login/default_user_images.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/default_user_images.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "grit/theme_resources.h"
+#include "ui/base/resource/resource_bundle.h"
 

[whywhat, 2011/11/11 15:40:42]

include SkBitmap.h?

[Ivan Korotkov, 2011/11/11 16:08:00]

Done.

 namespace chromeos {
 
 namespace {
 
 const char kDefaultPathPrefix[] = "default:";
 const char kDefaultUrlPrefix[] = "chrome://theme/IDR_LOGIN_DEFAULT_USER_";
 const char kFirstDefaultUrl[] = "chrome://theme/IDR_LOGIN_DEFAULT_USER";
 
 const char* kOldDefaultImageNames[] = {
   "default:gray",
@@ skipping 62 matching lines @@
 }
 
 bool IsDefaultImageUrl(const std::string url, int* image_id) {
   if (url == kFirstDefaultUrl) {
     *image_id = 0;
     return true;
   }
   return IsDefaultImageString(url, kDefaultUrlPrefix, image_id);
 }
 
+const SkBitmap& GetDefaultImage(int index) {

[whywhat, 2011/11/11 15:40:42]

God bless us if we keep this reference in UserManager singleton and
ResourceBundle dies before it...
AFAIK, SkBitmap is okay to copy as it shares pixels data 

[Ivan Korotkov, 2011/11/11 16:08:00]

Blessed are we.

+  DCHECK(index >= 0 && index < kDefaultImagesCount);
+  return *ResourceBundle::GetSharedInstance().
+      GetBitmapNamed(kDefaultImageResources[index]);
+}
+
 // Resource IDs of default user images.
 const int kDefaultImageResources[] = {
   IDR_LOGIN_DEFAULT_USER,
   IDR_LOGIN_DEFAULT_USER_1,
   IDR_LOGIN_DEFAULT_USER_2,
   IDR_LOGIN_DEFAULT_USER_3,
   IDR_LOGIN_DEFAULT_USER_4,
   IDR_LOGIN_DEFAULT_USER_5,
   IDR_LOGIN_DEFAULT_USER_6,
   IDR_LOGIN_DEFAULT_USER_7,
@@ skipping 14 matching lines @@
 
 // The order and the values of these constants are important for histograms
 // of different Chrome OS versions to be merged smoothly.
 const int kHistogramImageFromCamera = kDefaultImagesCount;
 const int kHistogramImageFromFile = kDefaultImagesCount + 1;
 const int kHistogramImageOld = kDefaultImagesCount + 2;
 const int kHistogramImageFromProfile = kDefaultImagesCount + 3;
 const int kHistogramImagesCount = kDefaultImagesCount + 4;
 
 }  // namespace chromeos