Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 854005: Enable TCMalloc on Linux by default. (Closed)

Created:
10 years, 9 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable TCMalloc on Linux by default. BUG=36687 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41457

Patch Set 1 #

Patch Set 2 : Add dependency for renderer. #

Patch Set 3 : Condition on linux_use_tcmalloc=1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
willchan no longer on Chromium
Now that agl has fixed http://crbug.com/36678, this should be good to go. I'm running the ...
10 years, 9 months ago (2010-03-12 00:46:55 UTC) #1
Lei Zhang
LGTM And this time I'm fairly confident it won't blow up.
10 years, 9 months ago (2010-03-12 00:52:33 UTC) #2
willchan no longer on Chromium
10 years, 9 months ago (2010-03-12 01:53:44 UTC) #3
Oops, looks like that LINUX_USE_TCMALLOC=>USE_TCMALLOC change made it so we need
an allocator dependency in the renderer library.  I've added it now.

Powered by Google App Engine
This is Rietveld 408576698