Issue 8540027: Disk Cache: Avoid discarding more deleted entries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8540027: Disk Cache: Avoid discarding more deleted entries (Closed)

Created:
9 years, 1 month ago by rvargas (doing something else)

Modified:
9 years, 1 month ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disk Cache: Avoid discarding more deleted entries than needed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110217

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	net/disk_cache/eviction.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/disk_cache/eviction.cc	View	1	3 chunks	+12 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gavinp

9 years, 1 month ago (2011-11-15 16:17:56 UTC) #3

LGTM.

http://codereview.chromium.org/8540027/diff/4002/net/disk_cache/eviction.cc
File net/disk_cache/eviction.cc (right):

http://codereview.chromium.org/8540027/diff/4002/net/disk_cache/eviction.cc#n...
net/disk_cache/eviction.cc:366: } else if (ShouldTrimDeleted()) {
Good catch.

Expand Messages | Collapse Messages