Issue 8540016: Heapchecker: Suppress new pepper plugin leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8540016: Heapchecker: Suppress new pepper plugin leaks. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Heapchecker: Suppress new pepper plugin leaks. BUG=103945 TEST=Heapchecker CrOS bot goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109706

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

lgtm, but could maybe simplify to { bug_103945a Heapcheck:Leak fun:std::string::_Rep::_S_create ... fun:PluginService::RegisterPepperPlugins fun:PluginService::Init fun:chromeos::::GViewRequestInterceptorTest::SetUp }

9 years, 1 month ago (2011-11-11 21:21:09 UTC) #2

Lei Zhang

9 years, 1 month ago (2011-11-11 21:27:48 UTC) #3

On 2011/11/11 21:21:09, rsesek wrote:
> lgtm, but could maybe simplify to 

Sure, the suppression that matches all 3 cases is actually a bit different. See
patch set 2.

Expand Messages | Collapse Messages

Issue 8540016: Heapchecker: Suppress new pepper plugin leaks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages