Issue 8540014: [cros, Aura] Fix login screen crash on boot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8540014: [cros, Aura] Fix login screen crash on boot. (Closed)

Created:
9 years, 1 month ago by oshima

Modified:
9 years, 1 month ago

Reviewers:
stevenjb, Nikita (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros, Aura] Fix login screen crash on boot. Crash was caused by the uninitialized ScreenAura instance used in chromeos::CalculateScreenBounds chrome/browser/chromeos/login/helper.cc:164 Moved initialization of login screen classes right before message loop start so that Desktop/Screen instances are initialized. Also fixed crash during sign in. TBR=nkostylev@chromium.org BUG=103892 TEST=Boot with Aura build, sign in. No crashes Original CL: http://codereview.chromium.org/8511059/ landing for nkostylev@chromium.org, Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109666

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm