Issue 8540007: Fixing build errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8540007: Fixing build errors. (Closed)

Created:
9 years, 1 month ago by Yang

Modified:
9 years, 1 month ago

Reviewers:
Sven Panne, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixing build errors. Committed: http://code.google.com/p/v8/source/detail?r=9981

Patch Set 2 : fixing copy-paste bug #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/runtime.cc	View	1	1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

http://codereview.chromium.org/8540007/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/8540007/diff/1/src/runtime.cc#newcode6977 src/runtime.cc:6977: max_string_length = SeqAsciiString::kMaxLength; No, no, no, no!

9 years, 1 month ago (2011-11-11 17:45:28 UTC) #2

Sven Panne

9 years, 1 month ago (2011-11-14 07:29:57 UTC) #4

http://codereview.chromium.org/8540007/diff/1002/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8540007/diff/1002/src/runtime.cc#newcode6978
src/runtime.cc:6978: }
Contrary to popular belief, the "ternary aversion" disease *is* curable! I
recommend a dose of Haskell or OCaml every day... ;-)

Expand Messages | Collapse Messages

Issue 8540007: Fixing build errors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixing copy-paste bug #

Messages