Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: src/frames-inl.h

Issue 8540005: Revert "Add a level of indirection to exception handler addresses." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.h ('k') | src/full-codegen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames-inl.h
diff --git a/src/frames-inl.h b/src/frames-inl.h
index af3ae3dfb6e7fb4d92d8d1887e0cdb552b3d07e8..94c745cfc28aa4ef6719db4e4c69120b540ff51e 100644
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -68,7 +68,7 @@ inline bool StackHandler::includes(Address address) const {
inline void StackHandler::Iterate(ObjectVisitor* v, Code* holder) const {
v->VisitPointer(context_address());
- v->VisitPointer(code_address());
+ StackFrame::IteratePc(v, pc_address(), holder);
}
@@ -78,23 +78,23 @@ inline StackHandler* StackHandler::FromAddress(Address address) {
inline bool StackHandler::is_entry() const {
- return kind() == ENTRY;
+ return state() == ENTRY;
}
inline bool StackHandler::is_try_catch() const {
- return kind() == TRY_CATCH;
+ return state() == TRY_CATCH;
}
inline bool StackHandler::is_try_finally() const {
- return kind() == TRY_FINALLY;
+ return state() == TRY_FINALLY;
}
-inline StackHandler::Kind StackHandler::kind() const {
+inline StackHandler::State StackHandler::state() const {
const int offset = StackHandlerConstants::kStateOffset;
- return KindField::decode(Memory::unsigned_at(address() + offset));
+ return static_cast<State>(Memory::int_at(address() + offset));
}
@@ -104,9 +104,9 @@ inline Object** StackHandler::context_address() const {
}
-inline Object** StackHandler::code_address() const {
- const int offset = StackHandlerConstants::kCodeOffset;
- return reinterpret_cast<Object**>(address() + offset);
+inline Address* StackHandler::pc_address() const {
+ const int offset = StackHandlerConstants::kPCOffset;
+ return reinterpret_cast<Address*>(address() + offset);
}
« no previous file with comments | « src/frames.h ('k') | src/full-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698