Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 8539051: aura: Touch state file after first browser is ready. (Closed)

Created:
9 years, 1 month ago by Daniel Erat
Modified:
9 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Chris Masone
Visibility:
Public.

Description

aura: Touch state file after first browser is ready. This creates a chromeos::InitialBrowserWindowObserver class for Aura that replicates some behavior for tests that's currently performed by the X window manager: when the first browser window is created, /var/run/state/windowmanager/initial-chrome-window-mapped is touched (the window manager actually writes the window's ID to the file, but that doesn't make sense under Aura and luckily doesn't appear to be depended on by any tests). This fixes Chrome OS's security_ProfilePermissions.BWSI and security_ProfilePermissions.login autotests, which otherwise time out when run against an Aura build. I'm also moving existing X-window-manager-related files that are currently in the chromeos/ directory to chromeos/legacy_window_manager/. BUG=chromium-os:22974, chromium-os:22896 TEST=manual: observed that tests no longer time out Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110508

Patch Set 1 #

Patch Set 2 : move ifdef #

Patch Set 3 : move to legacy_window_manager directory #

Patch Set 4 : merge #

Patch Set 5 : update more includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -664 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/layout_mode_button.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/legacy_window_manager/initial_browser_window_observer.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/legacy_window_manager/initial_browser_window_observer.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/legacy_window_manager/wm_ipc.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/legacy_window_manager/wm_ipc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/legacy_window_manager/wm_message_listener.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/legacy_window_manager/wm_message_listener.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/panels/panel_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/setting_level_bubble.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/wm_ipc.h View 1 2 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/browser/chromeos/wm_ipc.cc View 1 2 1 chunk +0 lines, -315 lines 0 comments Download
D chrome/browser/chromeos/wm_message_listener.h View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/wm_message_listener.cc View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_bubble_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
9 years, 1 month ago (2011-11-16 20:37:34 UTC) #1
DaveMoore
lgtm
9 years, 1 month ago (2011-11-16 23:33:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/8539051/4001
9 years, 1 month ago (2011-11-16 23:49:07 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 23:49:15 UTC) #4
Can't apply patch for file
chrome/browser/chromeos/chrome_browser_main_chromeos.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/chrome_browser_main_chromeos.cc
Hunk #2 FAILED at 170.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/chrome_browser_main_chromeos.cc.rej

Powered by Google App Engine
This is Rietveld 408576698