Stop using chrome/browser/ui/views/bubble/bubble.h in fullscreen exit bubble.

Stop using chrome/browser/ui/views/bubble/bubble.h in fullscreen exit bubble.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110444

[yzshen1, 2011-11-16 18:33:58]

Hi, Mike.

I didn't change the implementation to base on views/bubble/bubble_delegate.h,
because the difference seems significant, e.g., where to position the bubble,
animation effect, etc.

The original implementation didn't actually use
chrome/browser/ui/views/bubble/bubble.h. The only thing used was the bubble
background color. However, that wasn't necessary either, because we didn't paint
the arrow of the bubble border. So I simply removed it.

[msw, 2011-11-16 22:05:40]

This LGTM (with a nit), because the point of our work towards the deadline is to
remove dependencies on that old bubble code. I think we ought to transition this
class to use the new bubble code eventually, but this is great for now; thanks!

http://codereview.chromium.org/8539048/diff/1/chrome/browser/ui/views/fullscr...
File chrome/browser/ui/views/fullscreen_exit_bubble_views.cc (right):

http://codereview.chromium.org/8539048/diff/1/chrome/browser/ui/views/fullscr...
chrome/browser/ui/views/fullscreen_exit_bubble_views.cc:224: popup_ = new
views::Widget;
This wouldn't be necessary if we used the views bubble infrastructure.
Add a TODO or some comment to that effect here.

[yzshen1, 2011-11-17 00:55:45]

Thanks, Mike!

http://codereview.chromium.org/8539048/diff/1/chrome/browser/ui/views/fullscr...
File chrome/browser/ui/views/fullscreen_exit_bubble_views.cc (right):

http://codereview.chromium.org/8539048/diff/1/chrome/browser/ui/views/fullscr...
chrome/browser/ui/views/fullscreen_exit_bubble_views.cc:224: popup_ = new
views::Widget;
On 2011/11/16 22:05:40, msw wrote:
> This wouldn't be necessary if we used the views bubble infrastructure.
> Add a TODO or some comment to that effect here.

Done.

[commit-bot: I haz the power, 2011-11-17 00:56:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/8539048/5001

[commit-bot: I haz the power, 2011-11-17 05:22:34]

Change committed as 110444