Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: chrome/browser/chrome_browser_main_unittest.cc

Issue 8539038: Add ChromeBrowserMainExtraParts for non main parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase again + explicit reset of parts_ Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_browser_main_linux.cc ('k') | chrome/browser/chrome_browser_parts_aura.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "chrome/browser/chrome_browser_main.h" 10 #include "chrome/browser/chrome_browser_main.h"
(...skipping 12 matching lines...) Expand all
23 protected: 23 protected:
24 TestingPrefService pref_service_; 24 TestingPrefService pref_service_;
25 CommandLine command_line_; 25 CommandLine command_line_;
26 }; 26 };
27 27
28 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_WarmestSocket) { 28 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_WarmestSocket) {
29 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "0"); 29 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "0");
30 30
31 scoped_ptr<content::MainFunctionParams> params( 31 scoped_ptr<content::MainFunctionParams> params(
32 new content::MainFunctionParams(command_line_)); 32 new content::MainFunctionParams(command_line_));
33 ScopedVector<content::BrowserMainParts> bwv; 33 scoped_ptr<content::BrowserMainParts> bw(
34 content::GetContentClient()->browser()->CreateBrowserMainParts( 34 content::GetContentClient()->browser()->CreateBrowserMainParts(*params));
35 *params, &(bwv.get())); 35 ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());
36 ChromeBrowserMainParts* cbw = NULL;
37 if (bwv.size() >= 1)
38 cbw = static_cast<ChromeBrowserMainParts*>(bwv[0]);
39 EXPECT_TRUE(cbw); 36 EXPECT_TRUE(cbw);
40 if (cbw) { 37 if (cbw) {
41 cbw->WarmConnectionFieldTrial(); 38 cbw->WarmConnectionFieldTrial();
42 EXPECT_EQ(0, net::GetSocketReusePolicy()); 39 EXPECT_EQ(0, net::GetSocketReusePolicy());
43 } 40 }
44 } 41 }
45 42
46 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Random) { 43 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Random) {
47 scoped_ptr<content::MainFunctionParams> params( 44 scoped_ptr<content::MainFunctionParams> params(
48 new content::MainFunctionParams(command_line_)); 45 new content::MainFunctionParams(command_line_));
49 ScopedVector<content::BrowserMainParts> bwv; 46 scoped_ptr<content::BrowserMainParts> bw(
50 content::GetContentClient()->browser()->CreateBrowserMainParts( 47 content::GetContentClient()->browser()->CreateBrowserMainParts(*params));
51 *params, &(bwv.get())); 48 ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());
52 ChromeBrowserMainParts* cbw = NULL;
53 if (bwv.size() >= 1)
54 cbw = static_cast<ChromeBrowserMainParts*>(bwv[0]);
55 EXPECT_TRUE(cbw); 49 EXPECT_TRUE(cbw);
56 if (cbw) { 50 if (cbw) {
57 const int kNumRuns = 1000; 51 const int kNumRuns = 1000;
58 for (int i = 0; i < kNumRuns; i++) { 52 for (int i = 0; i < kNumRuns; i++) {
59 cbw->WarmConnectionFieldTrial(); 53 cbw->WarmConnectionFieldTrial();
60 int val = net::GetSocketReusePolicy(); 54 int val = net::GetSocketReusePolicy();
61 EXPECT_LE(val, 2); 55 EXPECT_LE(val, 2);
62 EXPECT_GE(val, 0); 56 EXPECT_GE(val, 0);
63 } 57 }
64 } 58 }
65 } 59 }
66 60
67 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Invalid) { 61 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Invalid) {
68 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "100"); 62 command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "100");
69 63
70 scoped_ptr<content::MainFunctionParams> params( 64 scoped_ptr<content::MainFunctionParams> params(
71 new content::MainFunctionParams(command_line_)); 65 new content::MainFunctionParams(command_line_));
72 // This test ends up launching a new process, and that doesn't initialize the 66 // This test ends up launching a new process, and that doesn't initialize the
73 // ContentClient interfaces. 67 // ContentClient interfaces.
74 ScopedVector<content::BrowserMainParts> bwv; 68 scoped_ptr<content::BrowserMainParts> bw;
75 if (content::GetContentClient()) { 69 if (content::GetContentClient()) {
76 content::GetContentClient()->browser()->CreateBrowserMainParts( 70 bw.reset(content::GetContentClient()->browser()->CreateBrowserMainParts(
77 *params, &(bwv.get())); 71 *params));
78 } else { 72 } else {
79 chrome::ChromeContentBrowserClient ccbc; 73 chrome::ChromeContentBrowserClient ccbc;
80 ccbc.CreateBrowserMainParts(*params, &(bwv.get())); 74 bw.reset(ccbc.CreateBrowserMainParts(*params));
81 } 75 }
82 ChromeBrowserMainParts* cbw = NULL; 76 ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());
83 if (bwv.size() >= 1)
84 cbw = static_cast<ChromeBrowserMainParts*>(bwv[0]);
85 EXPECT_TRUE(cbw); 77 EXPECT_TRUE(cbw);
86 if (cbw) { 78 if (cbw) {
87 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON) 79 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
88 EXPECT_DEATH(cbw->WarmConnectionFieldTrial(), 80 EXPECT_DEATH(cbw->WarmConnectionFieldTrial(),
89 "Not a valid socket reuse policy group"); 81 "Not a valid socket reuse policy group");
90 #else 82 #else
91 EXPECT_DEBUG_DEATH(cbw->WarmConnectionFieldTrial(), 83 EXPECT_DEBUG_DEATH(cbw->WarmConnectionFieldTrial(),
92 "Not a valid socket reuse policy group"); 84 "Not a valid socket reuse policy group");
93 #endif 85 #endif
94 } 86 }
95 } 87 }
OLDNEW
« no previous file with comments | « chrome/browser/chrome_browser_main_linux.cc ('k') | chrome/browser/chrome_browser_parts_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698