Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/browser/extensions/settings/settings_backend.h

Issue 8539037: Extension Settings API: make it so that when changes received from Sync fail to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable all sync, not just outgoing Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_backend.h
diff --git a/chrome/browser/extensions/settings/settings_backend.h b/chrome/browser/extensions/settings/settings_backend.h
index 1c6366fc5c2ce234aa9355e5a9cf9317f7eed7c9..2eb0fc82908fb696f265500dfaeec3c48c171e75 100644
--- a/chrome/browser/extensions/settings/settings_backend.h
+++ b/chrome/browser/extensions/settings/settings_backend.h
@@ -38,12 +38,7 @@ class SettingsBackend : public SyncableService {
// Gets a weak reference to the storage area for a given extension.
// Must be run on the FILE thread.
- //
- // By default this will be an SettingsLeveldbStorage, but on
- // failure to create a leveldb instance will fall back to
- // InMemorySettingsStorage.
- SettingsStorage* GetStorage(
- const std::string& extension_id) const;
+ SettingsStorage* GetStorage(const std::string& extension_id) const;
// Deletes all setting data for an extension. Call on the FILE thread.
void DeleteStorage(const std::string& extension_id);
@@ -72,6 +67,11 @@ class SettingsBackend : public SyncableService {
// installed extensions.
std::set<std::string> GetKnownExtensionIDs() const;
+ // Disable the syncing of the storage error for |extension_id|.
+ // Incoming sync changes will still be sent to the extension, just no sync
Matt Perry 2011/11/16 19:03:11 comment no longer accurate?
not at google - send to devlin 2011/11/16 21:11:51 Done.
+ // changes will generated by the extension.
+ void DisableSyncForExtension(const std::string& extension_id) const;
+
// The Factory to use for creating leveldb storage areas. Not owned.
SettingsStorageFactory* const storage_factory_;

Powered by Google App Engine
This is Rietveld 408576698