Issue 8539037: Extension Settings API: make it so that when changes received from Sync fail to

Issue 8539037: Extension Settings API: make it so that when changes received from Sync fail to (Closed)

Created:
9 years, 1 month ago by not at google - send to devlin

Modified:
9 years, 1 month ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extension Settings API: make it so that when changes received from sync fail to apply to an extension's settings, all sync for those settings is disabled. Likewise if local changes fail to be sent to sync. This makes sure that no invalid outgoing changes are sent to sync, or any local consistency violated. If sync is restarted, re-enable sync for that extension. BUG=103514 TEST=*ExtensionSettings* (unit_tests, browser_tests) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110371

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : disable all sync, not just outgoing #

Total comments: 2

Patch Set 5 : comments, sync #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+838 lines, -259 lines)			Patch
D	chrome/browser/extensions/settings/in_memory_settings_storage.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/extensions/settings/in_memory_settings_storage.cc	View		1 chunk	+0 lines, -97 lines	0 comments	Download
D	chrome/browser/extensions/settings/in_memory_settings_storage_unittest.cc	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_backend.h	View	1 2 3 4	2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_backend.cc	View	1 2	6 chunks	+29 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_frontend_unittest.cc	View		2 chunks	+1 line, -26 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_quota_unittest.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_storage_cache_unittest.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_sync_unittest.cc	View	1 2 3	7 chunks	+663 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_test_util.h	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/settings/settings_test_util.cc	View		3 chunks	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/settings/syncable_settings_storage.h	View	1 2 3	1 chunk	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/settings/syncable_settings_storage.cc	View	1 2 3	5 chunks	+17 lines, -14 lines	0 comments	Download
A +	chrome/browser/extensions/settings/testing_settings_storage.h	View		3 chunks	+14 lines, -7 lines	0 comments	Download
A +	chrome/browser/extensions/settings/testing_settings_storage.cc	View		6 chunks	+48 lines, -12 lines	0 comments	Download
A +	chrome/browser/extensions/settings/testing_settings_storage_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

(As before, see bug for more background)

9 years, 1 month ago (2011-11-14 07:36:33 UTC) #1

not at google - send to devlin

Since it doesn't seem like you've looked at this yet, I incorporated what I was ...

9 years, 1 month ago (2011-11-16 05:15:16 UTC) #2

Matt Perry

lgtm. Sorry, I had looked at this, I just forgot to send the lgtm. http://codereview.chromium.org/8539037/diff/7001/chrome/browser/extensions/settings/settings_backend.h ...

9 years, 1 month ago (2011-11-16 19:03:11 UTC) #3

not at google - send to devlin

http://codereview.chromium.org/8539037/diff/7001/chrome/browser/extensions/settings/settings_backend.h File chrome/browser/extensions/settings/settings_backend.h (right): http://codereview.chromium.org/8539037/diff/7001/chrome/browser/extensions/settings/settings_backend.h#newcode71 chrome/browser/extensions/settings/settings_backend.h:71: // Incoming sync changes will still be sent to ...

9 years, 1 month ago (2011-11-16 21:11:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8539037/11001

9 years, 1 month ago (2011-11-16 21:12:36 UTC) #5

Change committed as 110371

Expand Messages | Collapse Messages