Issue 8539036: base:Bind: Convert ipc/.

Issue 8539036: base:Bind: Convert ipc/. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews, darin-cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base:Bind: Convert ipc/. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109810

Patch Set 2 : Review fix. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -62 lines)			Patch
M	ipc/ipc_channel_proxy.cc	View		8 chunks	+17 lines, -18 lines	0 comments	Download
M	ipc/ipc_channel_win.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ipc/ipc_channel_win.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	ipc/ipc_logging.cc	View	1	4 chunks	+7 lines, -8 lines	0 comments	Download
M	ipc/ipc_sync_channel.cc	View		4 chunks	+11 lines, -9 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View		10 chunks	+25 lines, -19 lines	0 comments	Download
M	ipc/ipc_sync_message_filter.cc	View		3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/8539036/diff/1/ipc/ipc_logging.cc File ipc/ipc_logging.cc (right): http://codereview.chromium.org/8539036/diff/1/ipc/ipc_logging.cc#newcode35 ipc/ipc_logging.cc:35: DISABLE_RUNNABLE_METHOD_REFCOUNT(IPC::Logging); Remove, obsolete http://codereview.chromium.org/8539036/diff/1/ipc/ipc_logging.cc#newcode167 ipc/ipc_logging.cc:167: main_thread_->PostTask(FROM_HERE, base::Bind(&Logging::Log, this, data)); ...

9 years, 1 month ago (2011-11-12 03:49:49 UTC) #2

James Hawkins

9 years, 1 month ago (2011-11-12 18:02:18 UTC) #3

lgtm

Expand Messages | Collapse Messages