Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: chrome/browser/ui/panels/panel_settings_menu_model.cc

Issue 8539035: Fix 3 panel related bugs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_settings_menu_model.cc
diff --git a/chrome/browser/ui/panels/panel_settings_menu_model.cc b/chrome/browser/ui/panels/panel_settings_menu_model.cc
index ee869558661e6e729203c5633667eb21ba35b4d6..72c9c360be6755f23ece599aaa8bbba8c8046321 100644
--- a/chrome/browser/ui/panels/panel_settings_menu_model.cc
+++ b/chrome/browser/ui/panels/panel_settings_menu_model.cc
@@ -89,9 +89,8 @@ void PanelSettingsMenuModel::ExecuteCommand(int command_id) {
extension->id());
break;
case COMMAND_UNINSTALL:
- // TODO(jianli): Need to handle the case that the extension API requests
- // the panel to be closed when the uninstall dialog is still showing.
- // http://crbug.com/102742
+ // When the owning panel is being closed by the extension API, the
+ // currently showing uninstall dialog will also be dismissed.
extension_uninstall_dialog_.reset(
ExtensionUninstallDialog::Create(browser->GetProfile(), this));
extension_uninstall_dialog_->ConfirmUninstall(extension);

Powered by Google App Engine
This is Rietveld 408576698