chrome/browser/ui/panels/panel_browser_window_cocoa.mm - Issue 8539025: Fix Panel to always detect when a tab is added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_window_cocoa.mm

Issue 8539025: Fix Panel to always detect when a tab is added. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Test cleanup and fix Mac test hang Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_browser_window_cocoa.mm

diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm

index ccd8a234151b0f3c7fd4541a41f60cf4462f2dd8..64a9224b6b91c83c3ede9b80d9f15a5bef249576 100644

--- a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm

+++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm

@@ -248,7 +248,7 @@ void PanelBrowserWindowCocoa::DestroyPanelBrowser() {

void PanelBrowserWindowCocoa::DidCloseNativeWindow() {

DCHECK(!isClosed());

- panel_->manager()->Remove(panel_.get());

+ panel_->OnNativePanelClosed();

controller_ = NULL;

}