Bluetooth UI update.

Bluetooth UI update.

BUG=chromium:100392, chromium:102139
.
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109924

[flackr, 2011-11-11 19:46:47]

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/bluetooth_list_element.js
(right):

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_list_element.js:96: }
Style nit: The return isn't affected by the fact that it is existing so just use
if block to select method for node insertion:
if (existing)
  this.replace..
else
  this.append..
return true;

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_list_element.js:194: if (el)
This should always exist if everything's working, right? For cases where not
getting an element is an error you should use the return unconditionally so that
it will cause errors if something goes wrong rather than hiding them.

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/system_options.html (right):

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/system_options.html:74: 'Find
Devices'. -->
nit: Line up comment with previous line.

[kevers, 2011-11-11 20:44:22]

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/bluetooth_list_element.js
(right):

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_list_element.js:96: }
On 2011/11/11 19:46:47, flackr wrote:
> Style nit: The return isn't affected by the fact that it is existing so just
use
> if block to select method for node insertion:
> if (existing)
>   this.replace..
> else
>   this.append..
> return true;

Done.

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_list_element.js:194: if (el)
On 2011/11/11 19:46:47, flackr wrote:
> This should always exist if everything's working, right? For cases where not
> getting an element is an error you should use the return unconditionally so
that
> it will cause errors if something goes wrong rather than hiding them.

Correct, 'el' should always exist.

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/system_options.html (right):

http://codereview.chromium.org/8539022/diff/3001/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/system_options.html:74: 'Find
Devices'. -->
On 2011/11/11 19:46:47, flackr wrote:
> nit: Line up comment with previous line.

Done.

[flackr, 2011-11-11 22:55:38]

LGTM with nit.

http://codereview.chromium.org/8539022/diff/1011/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/bluetooth_list_element.js
(right):

http://codereview.chromium.org/8539022/diff/1011/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_list_element.js:214: if
(spinner)
Ditto here.

[kevers, 2011-11-14 17:51:16]

http://codereview.chromium.org/8539022/diff/1011/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/bluetooth_list_element.js
(right):

http://codereview.chromium.org/8539022/diff/1011/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/bluetooth_list_element.js:214: if
(spinner)
On 2011/11/11 22:55:38, flackr wrote:
> Ditto here.

Done.

[commit-bot: I haz the power, 2011-11-14 17:58:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/8539022/7001

[commit-bot: I haz the power, 2011-11-14 19:07:41]

Change committed as 109924