subprocess2.py - Issue 8539015: Add most of testing improvements without the tee-specific tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 8539015: Add most of testing improvements without the tee-specific tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 4708aadf362ee347cf3d6528acc3c9007c917208..afe5c75c17122b289c1a36acf1c8ddeeb3d28ca3 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -246,7 +246,7 @@ def communicate(args, timeout=None, **kwargs):

time.sleep(0.001)

# Now that the process died, reset the cursor and read the file.

buff.seek(0)

- out = [buff.read(), None]

+ out = (buff.read(), None)

return out, proc.returncode

« no previous file with comments | « no previous file | tests/subprocess2_test.py » ('j') | tests/subprocess2_test.py » ('J')