Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 8539015: Add most of testing improvements without the tee-specific tests (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add most of testing improvements without the tee-specific tests Change return value from list to tuple for communicate(timeout != None). R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110094

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -64 lines) Patch
M subprocess2.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/subprocess2_test.py View 6 chunks +169 lines, -63 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years, 1 month ago (2011-11-11 15:49:02 UTC) #1
Dirk Pranke
lgtm http://codereview.chromium.org/8539015/diff/1/tests/subprocess2_test.py File tests/subprocess2_test.py (right): http://codereview.chromium.org/8539015/diff/1/tests/subprocess2_test.py#newcode173 tests/subprocess2_test.py:173: class S2Test(unittest.TestCase): Nit: might be better not to ...
9 years, 1 month ago (2011-11-11 20:48:20 UTC) #2
M-A Ruel
http://codereview.chromium.org/8539015/diff/1/tests/subprocess2_test.py File tests/subprocess2_test.py (right): http://codereview.chromium.org/8539015/diff/1/tests/subprocess2_test.py#newcode173 tests/subprocess2_test.py:173: class S2Test(unittest.TestCase): On 2011/11/11 20:48:20, Dirk Pranke wrote: > ...
9 years, 1 month ago (2011-11-11 20:49:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8539015/1
9 years, 1 month ago (2011-11-15 15:44:51 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 15:50:52 UTC) #5
Change committed as 110094

Powered by Google App Engine
This is Rietveld 408576698