Issue 8539014: Export the AudioDevice and AudioDeviceInput classes so that unit tests have access to them in sha...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8539014: Export the AudioDevice and AudioDeviceInput classes so that unit tests have access to them in sha... (Closed)

Created:
9 years, 1 month ago by tommi (sloooow) - chröme

Modified:
9 years, 1 month ago

Reviewers:
ddorwin, henrika (OOO until Aug 14)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Export the AudioDevice and AudioDeviceInput classes so that unit tests have access to them in shared component builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109861

Patch Set 1 #

Patch Set 2 : added missing file #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
M	content/renderer/media/audio_device.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/media/audio_input_device.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/media/audio_input_message_filter.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

9 years, 1 month ago (2011-11-11 16:27:18 UTC) #7

LGTM
On Nov 11, 2011 7:54 AM, <henrika@chromium.org> wrote:

> LGTM++.
>
>
http://codereview.chromium.**org/8539014/<http://codereview.chromium.org/8539...
>

Expand Messages | Collapse Messages