Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 8539013: Export RenderWidgetHostViewAura and sensors::Provider to fix component build. (Closed)

Created:
9 years, 1 month ago by sadrul
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Export RenderWidgetHostViewAura and sensors::Provider to fix component build. TBR=ben@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/sensors/sensors_provider.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
9 years, 1 month ago (2011-11-11 14:18:35 UTC) #1
Ben Goodger (Google)
9 years, 1 month ago (2011-11-11 14:42:13 UTC) #2
LGTM.

On Fri, Nov 11, 2011 at 6:18 AM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Export RenderWidgetHostViewAura and sensors::Provider to fix component
> build.
>
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
> Committed: http://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=109624<http://src.chromium.org/viewvc/chrome?view=rev&revision=109624>
>
> Please review this at
http://codereview.chromium.**org/8539013/<http://codereview.chromium.org/8539...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M content/browser/renderer_host/**render_widget_host_view_aura.h
>  M content/browser/sensors/**sensors_provider.h
>
>
> Index: content/browser/renderer_host/**render_widget_host_view_aura.h
> diff --git a/content/browser/renderer_**host/render_widget_host_view_**aura.h
> b/content/browser/renderer_**host/render_widget_host_view_**aura.h
> index cdbf1e358e18fa3dbf0c77c346600f**884357ba28..**
> e15a0594813f4b4b909e97ca46a325**e2c80c1277 100644
> --- a/content/browser/renderer_**host/render_widget_host_view_**aura.h
> +++ b/content/browser/renderer_**host/render_widget_host_view_**aura.h
> @@ -9,6 +9,7 @@
>  #include <map>
>
>  #include "content/browser/renderer_**host/render_widget_host_view.**h"
> +#include "content/common/content_**export.h"
>  #include "ui/aura/window_delegate.h"
>  #include "ui/gfx/compositor/compositor_**observer.h"
>  #include "webkit/glue/webcursor.h"
> @@ -21,11 +22,11 @@ class WebTouchEvent;
>  class AcceleratedSurfaceContainerLin**ux;
>  #endif
>
> -class RenderWidgetHostViewAura : public RenderWidgetHostView,
> +class CONTENT_EXPORT RenderWidgetHostViewAura : public
> RenderWidgetHostView,
>  #if defined(UI_COMPOSITOR_IMAGE_**TRANSPORT)
> -                                 public ui::CompositorObserver,
> +                                                public
> ui::CompositorObserver,
>  #endif
> -                                 public aura::WindowDelegate {
> +                                                public
> aura::WindowDelegate {
>  public:
>   explicit RenderWidgetHostViewAura(**RenderWidgetHost* host);
>   virtual ~RenderWidgetHostViewAura();
> Index: content/browser/sensors/**sensors_provider.h
> diff --git a/content/browser/sensors/**sensors_provider.h
> b/content/browser/sensors/**sensors_provider.h
> index 72bc15fd24fb441396ea9913a37250**e04419734e..**
> e647a4feebb49fa00d3f58f91d2e05**8a1ccd364d 100644
> --- a/content/browser/sensors/**sensors_provider.h
> +++ b/content/browser/sensors/**sensors_provider.h
> @@ -7,6 +7,7 @@
>  #pragma once
>
>  #include "base/basictypes.h"
> +#include "content/common/content_**export.h"
>  #include "content/common/sensors_**listener.h"
>
>  // The sensors API will unify various types of sensor data into a set of
> @@ -22,7 +23,7 @@ namespace sensors {
>  // TODO(cwolfe): Finish defining the initial set of channels and replace
> this
>  // with the generic sensor provider.
>  //
> -class Provider {
> +class CONTENT_EXPORT Provider {
>  public:
>   static Provider* GetInstance();
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698