Issue 8539011: ARM: Implement runtime function for array literal transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8539011: ARM: Implement runtime function for array literal transitions. (Closed)

Created:
9 years, 1 month ago by danno

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: Implement runtime function for array literal transitions. Also simplify ia32 and x64 handing of the trace_elements_transition flag. R=jkummerow@chromium.org BUG=none TEST=array-literal-transitions.js Committed: http://code.google.com/p/v8/source/detail?r=9979

Patch Set 1 #

Patch Set 2 : fix flags #

Total comments: 1

Patch Set 3 : review feedback #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -146 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		2 chunks	+60 lines, -0 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		1 chunk	+5 lines, -49 lines	0 comments	Download
M	src/builtins.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+43 lines, -49 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		2 chunks	+40 lines, -46 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years, 1 month ago (2011-11-11 13:40:22 UTC) #2

LGTM with comment addressed.

http://codereview.chromium.org/8539011/diff/2001/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/8539011/diff/2001/src/objects-inl.h#newcode126
src/objects-inl.h:126: from_kind == FAST_SMI_ONLY_ELEMENTS;
FAST_DOUBLE_ELEMENTS

Expand Messages | Collapse Messages