Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8539010: Cleanup: Remove unneeded forward declarations from chrome/browser/extensions. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded forward declarations from chrome/browser/extensions. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109708

Patch Set 1 #

Patch Set 2 : remove the speech file that ran away, I will get it later #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -36 lines) Patch
M chrome/browser/extensions/extension_clear_api.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_api.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_message_handler.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_permissions_api.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sidebar_api.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tts_api_controller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_webrequest_api.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/extensions/external_extension_provider_impl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_extension_loader.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_frontend.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.h View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 10:10:25 UTC) #1
Aaron Boodman
lgtm
9 years, 1 month ago (2011-11-11 17:16:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8539010/1
9 years, 1 month ago (2011-11-11 19:40:01 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/extensions/speech_input/extension_speech_input_api.h. While running patch -p0 --forward --force; A chrome/browser/extensions/speech_input patching ...
9 years, 1 month ago (2011-11-11 19:40:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8539010/8001
9 years, 1 month ago (2011-11-11 20:39:04 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 21:40:38 UTC) #6 
Change committed as 109708

Powered by Google App Engine
This is Rietveld 408576698